Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Unified Diff: media/video/capture/mac/platform_video_capturing_mac.h

Issue 464363003: Mac QTKit Video Capture: Run QTCaptureSession teardown in UI thread, clean up -stopCapture use. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: shess@ comments: Moved input/output removal to one place, cleaned up input/output count Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/video/capture/mac/platform_video_capturing_mac.h
diff --git a/media/video/capture/mac/platform_video_capturing_mac.h b/media/video/capture/mac/platform_video_capturing_mac.h
index 29bc49715c56cdb4bae0c5dde5f05614f58706eb..ba9423ca236170c5e23150e666f300aa42780bad 100644
--- a/media/video/capture/mac/platform_video_capturing_mac.h
+++ b/media/video/capture/mac/platform_video_capturing_mac.h
@@ -21,7 +21,7 @@ class VideoCaptureDeviceMac;
// implementation.
- (id)initWithFrameReceiver:(media::VideoCaptureDeviceMac*)frameReceiver;
-// Set the frame receiver. This method executes the registration in mutual
+// Sets the frame receiver. This method executes the registration in mutual
// exclusion.
// TODO(mcasas): This method and stopCapture() are always called in sequence and
// this one is only used to clear the frameReceiver, investigate if both can be
@@ -31,8 +31,9 @@ class VideoCaptureDeviceMac;
// Sets which capture device to use by name passed as deviceId argument. The
// device names are usually obtained via VideoCaptureDevice::GetDeviceNames()
// method. This method will also configure all device properties except those in
-// setCaptureHeight:widht:frameRate. If |deviceId| is nil, all potential
-// configuration is torn down. Returns YES on sucess, NO otherwise.
+// setCaptureHeight:widht:frameRate. If |deviceId| is nil, capture is stopped
+// and all potential configuration is torn down. Returns YES on sucess, NO
+// otherwise.
- (BOOL)setCaptureDevice:(NSString*)deviceId;
// Configures the capture properties.
@@ -40,7 +41,7 @@ class VideoCaptureDeviceMac;
width:(int)width
frameRate:(float)frameRate;
-// Start video capturing, register observers. Returns YES on sucess, NO
+// Starts video capturing, register observers. Returns YES on sucess, NO
Scott Hess - ex-Googler 2014/08/18 18:23:40 If you're going there, you need "registers", too.
mcasas 2014/08/19 15:24:59 Done.
// otherwise.
- (BOOL)startCapture;

Powered by Google App Engine
This is Rietveld 408576698