Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Issue 464363002: Remove State struct from GrDrawState (Closed)

Created:
6 years, 4 months ago by egdaniel
Modified:
6 years, 4 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove State struct from GrDrawState BUG=skia: Committed: https://skia.googlesource.com/skia/+/8cbf3d5b17e5f95ed992c019fb6165f079c385ad

Patch Set 1 #

Patch Set 2 : Fix coverage so we store uinit8_t #

Patch Set 3 : Fix coverage using uint8 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -97 lines) Patch
M src/gpu/GrDrawState.h View 1 6 chunks +23 lines, -51 lines 0 comments Download
M src/gpu/GrDrawState.cpp View 1 2 15 chunks +43 lines, -46 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
egdaniel
Getting rid of this failed State struct experiment
6 years, 4 months ago (2014-08-13 14:19:35 UTC) #1
bsalomon
lgtm
6 years, 4 months ago (2014-08-13 14:28:43 UTC) #2
egdaniel
The CQ bit was checked by egdaniel@google.com
6 years, 4 months ago (2014-08-21 13:20:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/egdaniel@google.com/464363002/40001
6 years, 4 months ago (2014-08-21 13:20:30 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 13:27:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (40001) as 8cbf3d5b17e5f95ed992c019fb6165f079c385ad

Powered by Google App Engine
This is Rietveld 408576698