Issue 464343002: DevTools: align call stack rendering with the rest of the panels.

Issue 464343002: DevTools: align call stack rendering with the rest of the panels. (Closed)

Created:
6 years, 4 months ago by pfeldman

Modified:
6 years, 4 months ago

Reviewers:
sergeyv

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: align call stack rendering with the rest of the panels. R=sergeyv@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180177

Patch Set 1 #

Total comments: 1

Patch Set 2 : for landing #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -28 lines)			Patch
M	Source/devtools/front_end/common/ParsedURL.js	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/devtools/front_end/inspectorStyle.css	View		1 chunk	+1 line, -23 lines	0 comments	Download
M	Source/devtools/front_end/sdk/WorkerTargetManager.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/sources/CallStackSidebarPane.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/sources/ThreadsSidebarPane.js	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

sergeyv

lgtm with nit https://codereview.chromium.org/464343002/diff/1/Source/devtools/front_end/common/ParsedURL.js File Source/devtools/front_end/common/ParsedURL.js (left): https://codereview.chromium.org/464343002/diff/1/Source/devtools/front_end/common/ParsedURL.js#oldcode123 Source/devtools/front_end/common/ParsedURL.js:123: Do you really need want to ...

6 years, 4 months ago (2014-08-13 14:14:58 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/464343002/1

6 years, 4 months ago (2014-08-13 14:31:30 UTC) #4

pfeldman

6 years, 4 months ago (2014-08-13 14:59:47 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as 180177 (presubmit successful).

Expand Messages | Collapse Messages