Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 464333002: Fix Flate Test, also cleanup (Closed)

Created:
6 years, 4 months ago by hal.canary
Modified:
6 years, 4 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Fix Flate Test, also cleanup - Remove SkData double-unref to fix assert. - Re-enable the test with DEBUG (was disabled due to double-unref assert). - SkRandom instead of rand() for thread-safety. - General clean up of the test for readability. Motivation: I am investigating turning on SkFlate::HaveFlate on Windows. Committed: https://skia.googlesource.com/skia/+/bc677c801523034fd68261e843db597c6625a8bc

Patch Set 1 : Another Patch Set #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -46 lines) Patch
M tests/FlateTest.cpp View 2 chunks +59 lines, -46 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
hal.canary
ptal
6 years, 4 months ago (2014-08-13 13:33:59 UTC) #1
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 4 months ago (2014-08-13 13:34:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/464333002/1
6 years, 4 months ago (2014-08-13 13:35:04 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 4 months ago (2014-08-13 13:35:05 UTC) #4
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 4 months ago (2014-08-13 13:36:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/464333002/20001
6 years, 4 months ago (2014-08-13 13:37:04 UTC) #6
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 4 months ago (2014-08-13 13:37:06 UTC) #7
mtklein
lgtm
6 years, 4 months ago (2014-08-13 14:13:30 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 14:14:41 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (20001) as bc677c801523034fd68261e843db597c6625a8bc

Powered by Google App Engine
This is Rietveld 408576698