Support using TrackedCallbacks as hints to determine the handling thread of resource reply messages

ppapi/proxy/plugin_message_filter.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PPAPI_PROXY_PLUGIN_MESSAGE_FILTER_H_
 #define PPAPI_PROXY_PLUGIN_MESSAGE_FILTER_H_
 
 #include <set>
 
 #include "base/compiler_specific.h"
 #include "ipc/ipc_channel_proxy.h"
 #include "ipc/ipc_sender.h"
 #include "ppapi/c/pp_instance.h"
+#include "ppapi/proxy/ppapi_proxy_export.h"
 
 namespace ppapi {
 namespace proxy {
 
+class ResourceMessageReplyParams;
+class ResourceReplyThreadRegistrar;
+
 // Listens for messages on the I/O thread of the plugin and handles some of
 // them to avoid needing to block on the plugin.
 //
 // There is one instance of this class for each renderer channel (same as for
 // the PluginDispatchers).
-class PluginMessageFilter : public IPC::ChannelProxy::MessageFilter,
-                            public IPC::Sender {
+class PPAPI_PROXY_EXPORT PluginMessageFilter
+    : public IPC::ChannelProxy::MessageFilter,
+      public IPC::Sender {
  public:
   // The input is a pointer to a set that will be used to uniquify PP_Instances

[dmichael (off chromium), 2013/12/11 21:30:36]

nit: this documentation is a little out of date, with the new parameter.

[yzshen1, 2013/12/11 22:22:07]

I think you might be reading an old patchset.
Please take a look at the latest one. :)

On 2013/12/11 21:30:36, dmichael wrote:

   // across all renderer channels. The same pointer should be passed to each
   // MessageFilter to ensure uniqueness, and the value should outlive this
   // class.
-  PluginMessageFilter(std::set<PP_Instance>* seen_instance_ids);
+  PluginMessageFilter(
+      std::set<PP_Instance>* seen_instance_ids,
+      scoped_refptr<ResourceReplyThreadRegistrar> thread_registrar);
   virtual ~PluginMessageFilter();
 
   // MessageFilter implementation.
   virtual void OnFilterAdded(IPC::Channel* channel) OVERRIDE;
   virtual void OnFilterRemoved() OVERRIDE;
   virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
 
   // IPC::Sender implementation.
   virtual bool Send(IPC::Message* msg) OVERRIDE;
 
+  static void DispatchResourceReplyForTest(
+      const ResourceMessageReplyParams& reply_params,
+      const IPC::Message& nested_msg);
+
  private:
   void OnMsgReserveInstanceId(PP_Instance instance, bool* usable);
+  void OnMsgResourceReply(const ResourceMessageReplyParams& reply_params,
+                          const IPC::Message& nested_msg);
+
+  static void DispatchResourceReply(
+    const ResourceMessageReplyParams& reply_params,
+    const IPC::Message& nested_msg);
 
   // All instance IDs every queried by any renderer on this plugin. This is
   // used to make sure that new instance IDs are unique. This is a non-owning
   // pointer, it will be managed by the later that creates this class.

[dmichael (off chromium), 2013/12/11 21:30:36]

Not part of your CL, but...
"later"->"delegate"?

[yzshen1, 2013/12/11 22:22:07]

Done.

I changed to:
"It is managed by PluginDispatcher::PluginDelegate."

On 2013/12/11 21:30:36, dmichael wrote:

   std::set<PP_Instance>* seen_instance_ids_;
 
+  scoped_refptr<ResourceReplyThreadRegistrar> resource_reply_thread_registrar_;
+
   // The IPC channel to the renderer. May be NULL if we're not currently
   // attached as a filter.
   IPC::Channel* channel_;
 };
 
 }  // namespace proxy
 }  // namespace ppapi
 
 #endif  // PPAPI_PROXY_PLUGIN_MESSAGE_FILTER_H_