Source/core/inspector/InspectorInstrumentation.idl - Issue 464293002: [DevTools] ConsoleMessage storage moved from ConsoleAgent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorInstrumentation.idl

Issue 464293002: [DevTools] ConsoleMessage storage moved from ConsoleAgent (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@remove-can-generate

Patch Set: Rebased Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/inspector/InspectorConsoleAgent.cpp ('K') | « Source/core/inspector/InspectorController.cpp ('k') | Source/core/inspector/PageConsoleAgent.h » ('j') | Source/core/inspector/WorkerConsoleAgent.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/InspectorInstrumentation.idl

diff --git a/Source/core/inspector/InspectorInstrumentation.idl b/Source/core/inspector/InspectorInstrumentation.idl

index 2d95214221dc7cdfdaade1c9d6444267de122953..b47ee60cff61287b871c6878698dc42820ea2bad 100644

--- a/Source/core/inspector/InspectorInstrumentation.idl

+++ b/Source/core/inspector/InspectorInstrumentation.idl

@@ -482,7 +482,7 @@ class ConsoleMessage;

// Use the same implementation as above as a similar method dispatched on Page.

vsevik 2014/08/14 08:06:22 This comment seems obsolete.

kozyatinskiy1 2014/08/20 13:44:18 Done.

[Console]

- void addMessageToConsole(ExecutionContext* context, ConsoleMessage* consoleMessage);

+ void addMessageToConsole(ExecutionContext* context, PassRefPtr<ConsoleMessage> consoleMessage);

[Console, Debugger]

void addConsoleAPIMessageToConsole(ExecutionContext* context, MessageType type, MessageLevel level, const String& message, ScriptState* state, PassRefPtrWillBeRawPtr<ScriptArguments> arguments, unsigned long requestIdentifier = 0);