Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(956)

Unified Diff: Source/core/inspector/PageConsoleAgent.h

Issue 464293002: [DevTools] ConsoleMessage storage moved from ConsoleAgent (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@remove-can-generate
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/PageConsoleAgent.h
diff --git a/Source/core/inspector/PageConsoleAgent.h b/Source/core/inspector/PageConsoleAgent.h
index e2b53e2df6e6fa5661ac824f89bfe943bdf60c2f..4fa3e130fbde268b74a4556e65a94346f2568f7d 100644
--- a/Source/core/inspector/PageConsoleAgent.h
+++ b/Source/core/inspector/PageConsoleAgent.h
@@ -36,26 +36,32 @@
namespace blink {
+class ConsoleMessageStorage;
class InspectorDOMAgent;
+class Page;
class PageConsoleAgent FINAL : public InspectorConsoleAgent {
WTF_MAKE_NONCOPYABLE(PageConsoleAgent);
public:
- static PassOwnPtrWillBeRawPtr<PageConsoleAgent> create(InjectedScriptManager* injectedScriptManager, InspectorDOMAgent* domAgent, InspectorTimelineAgent* timelineAgent, InspectorTracingAgent* tracingAgent)
+ static PassOwnPtrWillBeRawPtr<PageConsoleAgent> create(InjectedScriptManager* injectedScriptManager, InspectorDOMAgent* domAgent, InspectorTimelineAgent* timelineAgent, InspectorTracingAgent* tracingAgent, Page* page)
{
- return adoptPtrWillBeNoop(new PageConsoleAgent(injectedScriptManager, domAgent, timelineAgent, tracingAgent));
+ return adoptPtrWillBeNoop(new PageConsoleAgent(injectedScriptManager, domAgent, timelineAgent, tracingAgent, page));
}
virtual ~PageConsoleAgent();
virtual void trace(Visitor*) OVERRIDE;
virtual bool isWorkerAgent() OVERRIDE { return false; }
+protected:
+ virtual ConsoleMessageStorage* messageStorage() OVERRIDE;
+
private:
- PageConsoleAgent(InjectedScriptManager*, InspectorDOMAgent*, InspectorTimelineAgent*, InspectorTracingAgent*);
+ PageConsoleAgent(InjectedScriptManager*, InspectorDOMAgent*, InspectorTimelineAgent*, InspectorTracingAgent*, Page*);
virtual void clearMessages(ErrorString*) OVERRIDE;
virtual void addInspectedNode(ErrorString*, int nodeId) OVERRIDE;
RawPtrWillBeMember<InspectorDOMAgent> m_inspectorDOMAgent;
+ RawPtr<Page> m_page;
aandrey 2014/08/26 08:56:42 RawPtrWillBeMember<Page> + add to trace() method
kozyatinskiy1 2014/08/26 09:39:29 Done.
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698