Source/core/frame/LocalFrame.cpp - Issue 464293002: [DevTools] ConsoleMessage storage moved from ConsoleAgent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/LocalFrame.cpp

Issue 464293002: [DevTools] ConsoleMessage storage moved from ConsoleAgent (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@remove-can-generate

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/frame/FrameConsole.cpp ('K') | « Source/core/frame/LocalDOMWindow.cpp ('k') | Source/core/inspector/CodeGeneratorInstrumentation.py » ('j') | Source/core/inspector/ConsoleMessage.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/frame/LocalFrame.cpp

diff --git a/Source/core/frame/LocalFrame.cpp b/Source/core/frame/LocalFrame.cpp

index 9a41e1ef6dbb2d99a4abf8a1a8f74ad31889c6cd..b1c3b02bc2fed3a9742a82ef24f366df59e0847e 100644

--- a/Source/core/frame/LocalFrame.cpp

+++ b/Source/core/frame/LocalFrame.cpp

@@ -233,7 +233,10 @@ FloatSize LocalFrame::resizePageRectsKeepingRatio(const FloatSize& originalSize,

void LocalFrame::setDOMWindow(PassRefPtrWillBeRawPtr<LocalDOMWindow> domWindow)

{

- InspectorInstrumentation::frameWindowDiscarded(this, m_domWindow.get());

+ if (m_domWindow.get()) {

aandrey 2014/08/26 08:56:42 if (m_domWindow)

kozyatinskiy1 2014/08/26 09:39:29 Done.

+ console().messageStorage()->windowCleared(m_domWindow.get());

+ InspectorInstrumentation::frameWindowDiscarded(this, m_domWindow.get());

+ }

if (domWindow)

aandrey 2014/08/26 08:56:42 join with the if- above?

kozyatinskiy1 2014/08/26 09:39:29 There are two different values: m_domWindow - curr

script().clearWindowProxy();

Frame::setDOMWindow(domWindow);