Source/core/frame/FrameConsole.h - Issue 464293002: [DevTools] ConsoleMessage storage moved from ConsoleAgent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/FrameConsole.h

Issue 464293002: [DevTools] ConsoleMessage storage moved from ConsoleAgent (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@remove-can-generate

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/frame/FrameConsole.h

diff --git a/Source/core/frame/FrameConsole.h b/Source/core/frame/FrameConsole.h

index 059e02f13f84204d83d3ebe330a2145eeea6dd21..a8b983a5cd74ed3e82bb9945aa83349e765b4e94 100644

--- a/Source/core/frame/FrameConsole.h

+++ b/Source/core/frame/FrameConsole.h

@@ -31,6 +31,7 @@

#include "bindings/core/v8/ScriptState.h"

#include "core/frame/ConsoleTypes.h"

+#include "core/inspector/ConsoleMessageStorage.h"

vsevik 2014/08/25 13:04:01 Is this needed?

kozyatinskiy1 2014/08/25 14:12:39 Yes, because FrameConsole uses default destructor.

#include "platform/heap/Handle.h"

#include "wtf/Forward.h"

#include "wtf/PassOwnPtr.h"

@@ -56,10 +57,14 @@ public:

static void mute();

static void unmute();

+ ConsoleMessageStorage* messageStorage();

private:

explicit FrameConsole(LocalFrame&);

LocalFrame& m_frame;

+ OwnPtr<ConsoleMessageStorage> m_consoleMessageStorage;

};

} // namespace blink

« no previous file with comments | « Source/core/core.gypi ('k') | Source/core/frame/FrameConsole.cpp » ('j') | Source/core/inspector/ConsoleMessageStorage.h » ('J')