Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Side by Side Diff: Source/core/frame/FrameConsole.h

Issue 464293002: [DevTools] ConsoleMessage storage moved from ConsoleAgent (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@remove-can-generate
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/core.gypi ('k') | Source/core/frame/FrameConsole.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Apple Inc. All rights reserved. 2 * Copyright (C) 2013 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 13 matching lines...) Expand all
24 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF 25 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
26 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 */ 27 */
28 28
29 #ifndef FrameConsole_h 29 #ifndef FrameConsole_h
30 #define FrameConsole_h 30 #define FrameConsole_h
31 31
32 #include "bindings/core/v8/ScriptState.h" 32 #include "bindings/core/v8/ScriptState.h"
33 #include "core/frame/ConsoleTypes.h" 33 #include "core/frame/ConsoleTypes.h"
34 #include "core/inspector/ConsoleMessageStorage.h"
yurys 2014/08/29 08:22:19 This include can be removed now:)
kozyatinskiy1 2014/08/29 08:26:45 Done.
34 #include "platform/heap/Handle.h" 35 #include "platform/heap/Handle.h"
35 #include "wtf/Forward.h" 36 #include "wtf/Forward.h"
36 #include "wtf/PassOwnPtr.h" 37 #include "wtf/PassOwnPtr.h"
37 38
38 namespace blink { 39 namespace blink {
39 40
40 class ConsoleMessage; 41 class ConsoleMessage;
42 class ConsoleMessageStorage;
41 class FrameHost; 43 class FrameHost;
42 class ScriptCallStack; 44 class ScriptCallStack;
43 class WorkerGlobalScopeProxy; 45 class WorkerGlobalScopeProxy;
44 46
45 // FrameConsole takes per-frame console messages and routes them up through the FrameHost to the ChromeClient and Inspector. 47 // FrameConsole takes per-frame console messages and routes them up through the FrameHost to the ChromeClient and Inspector.
46 // It's meant as an abstraction around ChromeClient calls and the way that Blink core/ can add messages to the console. 48 // It's meant as an abstraction around ChromeClient calls and the way that Blink core/ can add messages to the console.
47 class FrameConsole FINAL { 49 class FrameConsole FINAL {
48 public: 50 public:
49 static PassOwnPtr<FrameConsole> create(LocalFrame& frame) { return adoptPtr( new FrameConsole(frame)); } 51 static PassOwnPtr<FrameConsole> create(LocalFrame& frame) { return adoptPtr( new FrameConsole(frame)); }
52 ~FrameConsole();
50 53
51 void addMessage(PassRefPtrWillBeRawPtr<ConsoleMessage>); 54 void addMessage(PassRefPtrWillBeRawPtr<ConsoleMessage>);
52 void adoptWorkerConsoleMessages(WorkerGlobalScopeProxy*); 55 void adoptWorkerConsoleMessages(WorkerGlobalScopeProxy*);
53 56
54 static String formatStackTraceString(const String& originalMessage, PassRefP trWillBeRawPtr<ScriptCallStack>); 57 static String formatStackTraceString(const String& originalMessage, PassRefP trWillBeRawPtr<ScriptCallStack>);
55 58
56 static void mute(); 59 static void mute();
57 static void unmute(); 60 static void unmute();
58 61
62 ConsoleMessageStorage* messageStorage();
63
59 private: 64 private:
60 explicit FrameConsole(LocalFrame&); 65 explicit FrameConsole(LocalFrame&);
61 66
62 LocalFrame& m_frame; 67 LocalFrame& m_frame;
68
69 OwnPtr<ConsoleMessageStorage> m_consoleMessageStorage;
63 }; 70 };
64 71
65 } // namespace blink 72 } // namespace blink
66 73
67 #endif // FrameConsole_h 74 #endif // FrameConsole_h
OLDNEW
« no previous file with comments | « Source/core/core.gypi ('k') | Source/core/frame/FrameConsole.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698