Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 464283002: [oilpan] Null pointers must be treated as live, since they can't be marked live by strongification (Closed)

Created:
6 years, 4 months ago by Erik Corry
Modified:
6 years, 4 months ago
CC:
blink-reviews, haraken, kouhei+heap_chromium.org, Mads Ager (chromium)
Project:
blink
Visibility:
Public.

Description

[oilpan] Null pointers must be treated as live, since they can't be marked live by strongification R=ager@chromium.org, haraken@chromium.org BUG=402426 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180173

Patch Set 1 #

Patch Set 2 : Spelling fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M Source/platform/heap/HeapTest.cpp View 1 chunk +18 lines, -0 lines 0 comments Download
M Source/platform/heap/Visitor.h View 1 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 15 (0 generated)
Erik Corry
6 years, 4 months ago (2014-08-13 11:11:30 UTC) #1
Mads Ager (chromium)
LGTM, thanks Erik
6 years, 4 months ago (2014-08-13 11:15:39 UTC) #2
Mads Ager (chromium)
The CQ bit was checked by ager@chromium.org
6 years, 4 months ago (2014-08-13 11:18:17 UTC) #3
Erik Corry
The CQ bit was checked by erik.corry@gmail.com
6 years, 4 months ago (2014-08-13 11:18:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erik.corry@gmail.com/464283002/1
6 years, 4 months ago (2014-08-13 11:18:27 UTC) #5
Erik Corry
The CQ bit was unchecked by erik.corry@gmail.com
6 years, 4 months ago (2014-08-13 11:19:17 UTC) #6
Erik Corry
The CQ bit was checked by erik.corry@gmail.com
6 years, 4 months ago (2014-08-13 11:20:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erik.corry@gmail.com/464283002/20001
6 years, 4 months ago (2014-08-13 11:20:31 UTC) #8
haraken
LGTM. Thanks for fixing this!
6 years, 4 months ago (2014-08-13 11:24:24 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_gn_rel on tryserver.blink ...
6 years, 4 months ago (2014-08-13 13:02:19 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 13:05:54 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_chromium_gn_rel/builds/7319)
6 years, 4 months ago (2014-08-13 13:05:55 UTC) #12
Mads Ager (chromium)
The CQ bit was checked by ager@chromium.org
6 years, 4 months ago (2014-08-13 14:11:29 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erik.corry@gmail.com/464283002/20001
6 years, 4 months ago (2014-08-13 14:12:32 UTC) #14
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 14:13:38 UTC) #15
Message was sent while issue was closed. 
Committed patchset #2 (20001) as 180173

Powered by Google App Engine
This is Rietveld 408576698