Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 464253002: Revert of Revert "Revert of [oilpan]: Change marking to do precise roots first and conservative (Closed)

Created:
6 years, 4 months ago by Mads Ager (chromium)
Modified:
6 years, 4 months ago
CC:
blink-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Project:
blink
Visibility:
Public.

Description

Revert of Revert "Revert of [oilpan]: Change marking to do precise roots first and conservative second. (http… (patchset #2 of https://codereview.chromium.org/413133006/) Reason for revert: This breaks strongification of ephemerons when there are pointers on the stack. See: https://codereview.chromium.org/461413002/ for details. Original issue's description: > Revert "Revert of [oilpan]: Change marking to do precise roots first and conservative second. (https://codereview.chromium.org/405403003/)" > > This reverts commit 765af3a45b15c4e5f65810c8ed8e20d44da04034. > > AFAICT the CrossThreadPointerToOrphanedPage test was a bit flaky in the sense that the compiler was free to reuse the slot where the stackPtrValue was located after the RELEASE_ASSERT. However the test assumed the stackPtrValue was on the stack (to mimic a rogue integer value finding a dead object) when doing the conservative GC further down. > After my change to Heap::CollectGarbage it seemed the android compiler no longer kept the value around and hence the test started failing. I have now moved the RELEASE_ASSERT down to after the point where we do the conservative GC which makes the test pass on android again. > > I uploaded the unfixed diff first and then a second diff (moved RELEASE_ASSERT) with the fix. > > R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, sigbjornf@opera.com, tkent@chromium.org, zerny@chromium.org > BUG= > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178845 NOTRY=true NOTREECHECKS=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180160

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -70 lines) Patch
M Source/platform/heap/Heap.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/platform/heap/Heap.cpp View 4 chunks +13 lines, -44 lines 0 comments Download
M Source/platform/heap/HeapTest.cpp View 2 chunks +2 lines, -7 lines 0 comments Download
M Source/platform/heap/ThreadState.h View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/platform/heap/ThreadState.cpp View 4 chunks +19 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Mads Ager (chromium)
Created Revert of Revert "Revert of [oilpan]: Change marking to do precise roots first and ...
6 years, 4 months ago (2014-08-13 09:07:54 UTC) #1
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-13 09:08:56 UTC) #2
haraken
LGTM
6 years, 4 months ago (2014-08-13 09:11:05 UTC) #3
Mads Ager (google)
The CQ bit was checked by ager@google.com
6 years, 4 months ago (2014-08-13 09:16:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ager@chromium.org/464253002/1
6 years, 4 months ago (2014-08-13 09:18:48 UTC) #5
Mads Ager (chromium)
The CQ bit was unchecked by ager@chromium.org
6 years, 4 months ago (2014-08-13 09:21:44 UTC) #6
Mads Ager (chromium)
The CQ bit was checked by ager@chromium.org
6 years, 4 months ago (2014-08-13 09:21:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ager@chromium.org/464253002/1
6 years, 4 months ago (2014-08-13 09:22:53 UTC) #8
commit-bot: I haz the power
Change committed as 180160
6 years, 4 months ago (2014-08-13 09:23:22 UTC) #9
Mads Ager (chromium)
6 years, 4 months ago (2014-08-13 11:20:36 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1) has been created in
https://codereview.chromium.org/468083002/ by ager@chromium.org.

The reason for reverting is: This change did not contain the bug it just made it
much more likely that we would see it. Reapplying (again). :).

Powered by Google App Engine
This is Rietveld 408576698