Allow undefined data param to <appview>.connect

chrome/test/data/extensions/platform_apps/app_view/shim/main.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var util = {};
 var embedder = {};
 embedder.baseGuestURL = '';
 embedder.emptyGuestURL = '';
 embedder.windowOpenGuestURL = '';
 embedder.noReferrerGuestURL = '';
@@ skipping 50 matching lines @@
 };
 
 embedder.test.assertFalse = function(condition) {
   if (condition) {
     console.log('assertion failed: false != ' + condition);
     embedder.test.fail();
   }
 };
 
 // Tests begin.
 function testAppViewBasic(appToEmbed) {

[Xi Han, 2014/08/14 18:30:17]

Maybe we can change the name of this test to be more meaningful, like
testAppViewWithUndefinedDataShouldSucceed.

   var appview = new AppView();
   LOG('appToEmbed  ' + appToEmbed);
   // Step 1: Attempt to connect to a non-existant app.
   LOG('attempting to connect to non-existant app.');
-  appview.connect('abc123', {}, function(success) {
+  appview.connect('abc123', undefined, function(success) {
     // Make sure we fail.
     if (success) {
       embedder.test.fail();
       return;
     }
     LOG('failed to connect to non-existant app.');
     LOG('attempting to connect to known app.');
     // Step 2: Attempt to connect to an app we know exists.
-    appview.connect(appToEmbed, {}, function(success) {
+    appview.connect(appToEmbed, undefined, function(success) {
       // Make sure we don't fail.
       if (!success) {
         embedder.test.fail();
         return;
       }
       embedder.test.succeed();
     });
   });
   document.body.appendChild(appview);
 };
@@ skipping 34 matching lines @@
   'testAppViewRefusedDataShouldFail': testAppViewRefusedDataShouldFail,
   'testAppViewGoodDataShouldSucceed': testAppViewGoodDataShouldSucceed
 };
 
 onload = function() {
   chrome.test.getConfig(function(config) {
     embedder.setUp_(config);
     chrome.test.sendMessage('Launched');
   });
 };