content: Fix a clobber build of GN.

content: Fix a clobber build of GN.

ninja: error: 'gen/webkit/blink_resources.pak', needed by
'obj/content/shell/pak.inputdeps.stamp', missing and no known rule to
make it

The right patch should be:
$root_gen_dir/blink/public/resources/blink_resources.pak

This one:
ninja: error: 'gen/webkit/webkit_resources_100_percent.pak', needed by 'obj/content/shell/pak.inputdeps.stamp', missing and no known rule to make it

was very likely caused by https://chromium.googlesource.com/chromium/src.git/+/4eebe74dc1fd6d3780180361f75707a6be33c3ce

BUG=None
TEST=None
TBR=brettw@chromium.org

[tfarina, 2014-08-13 04:40:47]

TBRing! As it is a build fix.

[tfarina, 2014-08-13 04:50:13]

Brett, I don't understand the extensions/ error:

ninja: error: 'gen/chrome/common/common_resources.pak', needed by
'obj/extensions/shell_and_test_pak.inputdeps.stamp', missing and no known rule
to make it

If you look at //extensions:shell_and_test_pak you will see it includes
$root_gen_dir/chrome/common/common_resources.pak and depends on
//chrome:resources and chrome:resources depends on chrome/common:resources.

So I don't see what is wrong, I also see in my local build common_resources.pak
generated in out/Debug_gn/gen/chrome/common/

[tfarina, 2014-08-13 04:50:19]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2014-08-13 04:51:00]

kalman, yoz and jamescook, fyi for the //extensions:shell_and_test_pak error!

[commit-bot: I haz the power, 2014-08-13 04:51:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tfarina@chromium.org/464203002/20001

[tfarina, 2014-08-13 05:00:46]

I see!

chrome/common/BUILD.gn:17 -> output_dir = "$root_gen_dir/chrome"

so the correct path to common_resources.pak should be 
$root_gen_dir/chrome/common_resources.pak

[tfarina, 2014-08-13 05:05:29]

OK. extensions:shell_and_test_pak fully fixed now!

$ rm -rf out/Debug_gn

$ gn gen out/Debug_gn 
Done. Wrote 1247 targets from 437 files in 1726ms

$ ninja -C out/Debug_gn extensions:shell_and_test_pak
ninja: Entering directory `out/Debug_gn'
[252/252] STAMP obj/extensions/shell_and_test_pak.stamp

[tfarina, 2014-08-13 05:05:56]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-08-13 05:06:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tfarina@chromium.org/464203002/40001

[commit-bot: I haz the power, 2014-08-13 06:33:12]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-08-13 10:22:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-13 10:22:35]

Failed to apply patch for extensions/BUILD.gn:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file extensions/BUILD.gn
  Hunk #1 FAILED at 82.
  1 out of 1 hunk FAILED -- saving rejects to file extensions/BUILD.gn.rej

Patch:       extensions/BUILD.gn
Index: extensions/BUILD.gn
diff --git a/extensions/BUILD.gn b/extensions/BUILD.gn
index
f8fee97922b44222c73e6b5b5896ff0e682b8d1f..011221e8c417e15fa3b1a34ee8144e066f3787b1
100644
--- a/extensions/BUILD.gn
+++ b/extensions/BUILD.gn
@@ -82,12 +82,12 @@ source_set("test_support") {
 # GYP version: //extensions/extensions.gyp:extensions_shell_and_test_pak
 repack("shell_and_test_pak") {
   sources = [
-    "$root_gen_dir/chrome/common/common_resources.pak",
-    "$root_gen_dir/chrome/common/extensions_api_resources.pak",
+    "$root_gen_dir/chrome/common_resources.pak",
+    "$root_gen_dir/chrome/extensions_api_resources.pak",
     # TODO(jamescook): Extract the extension/app related resources
     # from generated_resources_en-US.pak. http://crbug.com/397250
     "$root_gen_dir/chrome/generated_resources_en-US.pak",
-    "$root_gen_dir/chrome/renderer/renderer_resources_100_percent.pak",
+    "$root_gen_dir/chrome/renderer_resources_100_percent.pak",
     "$root_gen_dir/content/content_resources.pak",
     "$root_gen_dir/content/shell/shell_resources.pak",
     "$root_gen_dir/extensions/extensions_renderer_resources.pak",

[tfarina, 2014-08-13 13:43:09]

Looks like this ended up being fixed in ->
https://codereview.chromium.org/468733003/

[James Cook, 2014-08-13 15:35:14]

On 2014/08/13 13:43:09, tfarina wrote:
> Looks like this ended up being fixed in ->
> https://codereview.chromium.org/468733003/

Do you know if app_shell or app_shell_browsertests is compiled as part of the GN
build?

[tfarina, 2014-08-13 16:06:26]

On 2014/08/13 15:35:14, James Cook wrote:
> On 2014/08/13 13:43:09, tfarina wrote:
> > Looks like this ended up being fixed in ->
> > https://codereview.chromium.org/468733003/
> 
> Do you know if app_shell or app_shell_browsertests is compiled as part of the
GN
> build?

No. extensions/shell/app_shell.gyp is not ported to GN yet.