Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 464163003: Remove IDR_STATUS_TRAY_ICON_PRESSED (Closed)

Created:
6 years, 4 months ago by Jitu( very slow this week)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove IDR_STATUS_TRAY_ICON_PRESSED IDR_STATUS_TRAY_ICON_PRESSED is only used in unit testcases. So we remove this so that it should not endup in pak files. BUG=367339 Committed: https://crrev.com/72d3e5c09036e3bebdf5d52081e70113e53b4331 Cr-Commit-Position: refs/heads/master@{#294324}

Patch Set 1 #

Patch Set 2 : Removed .mm file changes from patch #

Patch Set 3 : added .mm file #

Patch Set 4 : Fix the testcases error #

Patch Set 5 : remove png file #

Total comments: 2

Patch Set 6 : Removed SetPressedImage API #

Patch Set 7 : Removed SetPressedImage API #

Patch Set 8 : Removed from gtk2_status_icon and UT files #

Total comments: 1

Patch Set 9 : Updated the comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -52 lines) Patch
M chrome/app/theme/chrome_unscaled_resources.grd View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
D chrome/app/theme/chromium/product_logo_22_mono_invert.png View 3 4 Binary file 0 comments Download
M chrome/browser/background/background_mode_manager_unittest.cc View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/status_icons/status_icon.h View 1 2 3 4 5 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/status_icons/status_icon_menu_model_unittest.cc View 1 2 3 4 5 6 7 8 3 chunks +2 lines, -6 lines 0 comments Download
M chrome/browser/status_icons/status_icon_unittest.cc View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/status_icons/status_tray_unittest.cc View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/status_icons/status_icon_mac.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/status_icons/status_icon_mac.mm View 1 2 3 4 5 6 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/status_icons/status_icon_mac_unittest.mm View 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/app_indicator_icon.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/app_indicator_icon.cc View 1 2 3 4 5 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_status_icon.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/libgtk2ui/gtk2_status_icon.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/status_icons/status_icon_linux_wrapper.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/status_icons/status_icon_linux_wrapper.cc View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/status_icons/status_icon_win.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/status_icons/status_icon_win.cc View 1 2 3 4 5 6 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/status_icons/status_tray_win_unittest.cc View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/linux_ui/status_icon_linux.h View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 21 (6 generated)
Jitu( very slow this week)
PTAL
6 years, 3 months ago (2014-09-08 14:08:45 UTC) #2
Andrew T Wilson (Slow)
We should remove SetPressedImage() entirely, not just the asset and callers. https://codereview.chromium.org/464163003/diff/80001/chrome/app/theme/chrome_unscaled_resources.grd File chrome/app/theme/chrome_unscaled_resources.grd (left): ...
6 years, 3 months ago (2014-09-08 22:59:17 UTC) #3
Jitu( very slow this week)
@Andrew, PTAL ... I have removed all code related to SetPressedImage, But don't understand why ...
6 years, 3 months ago (2014-09-09 12:04:27 UTC) #4
Andrew T Wilson (Slow)
lgtm, if you change the comment I mentioned. I don't see any failing tests that ...
6 years, 3 months ago (2014-09-09 12:45:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jitendra.ks@samsung.com/464163003/160001
6 years, 3 months ago (2014-09-09 14:10:23 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/9626)
6 years, 3 months ago (2014-09-09 14:15:22 UTC) #9
Jitu( very slow this week)
Hi, I am getting below error when submitting the patch, Please help me out in ...
6 years, 3 months ago (2014-09-09 14:16:58 UTC) #10
Bernhard Bauer
On 2014/09/09 14:16:58, Jitu wrote: > Hi, > > I am getting below error when ...
6 years, 3 months ago (2014-09-09 14:18:26 UTC) #11
Jitu( very slow this week)
@Sky, PTAL ...
6 years, 3 months ago (2014-09-09 14:39:02 UTC) #13
Jitu( very slow this week)
Hi Ben and Sky, PTAL... This patch required owners approval.
6 years, 3 months ago (2014-09-10 03:30:56 UTC) #15
sky
LGTM
6 years, 3 months ago (2014-09-10 14:39:59 UTC) #16
sky
Update subject before landing, it is no longer WIP
6 years, 3 months ago (2014-09-10 14:40:15 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/464163003/160001
6 years, 3 months ago (2014-09-11 05:25:13 UTC) #19
commit-bot: I haz the power
Committed patchset #9 (id:160001) as 2aefaa063d2a96a9a676a9bb040a9ebe890415f4
6 years, 3 months ago (2014-09-11 05:36:08 UTC) #20
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 05:40:13 UTC) #21
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/72d3e5c09036e3bebdf5d52081e70113e53b4331
Cr-Commit-Position: refs/heads/master@{#294324}

Powered by Google App Engine
This is Rietveld 408576698