Remove IDR_STATUS_TRAY_ICON_PRESSED

Remove IDR_STATUS_TRAY_ICON_PRESSED

IDR_STATUS_TRAY_ICON_PRESSED is only used in unit testcases. So we remove
this so that it should not endup in pak files.

BUG=367339
Committed: https://crrev.com/72d3e5c09036e3bebdf5d52081e70113e53b4331
Cr-Commit-Position: refs/heads/master@{#294324}

[Jitu( very slow this week), 2014-09-08 14:08:45]

jitendra.ks@samsung.com changed reviewers:
+ atwilson@chromium.org, bauerb@chromium.org, thestig@chromium.org

[Jitu( very slow this week), 2014-09-08 14:08:45]

PTAL

[Andrew T Wilson (Slow), 2014-09-08 22:59:17]

We should remove SetPressedImage() entirely, not just the asset and callers.

https://codereview.chromium.org/464163003/diff/80001/chrome/app/theme/chrome_...
File chrome/app/theme/chrome_unscaled_resources.grd (left):

https://codereview.chromium.org/464163003/diff/80001/chrome/app/theme/chrome_...
chrome/app/theme/chrome_unscaled_resources.grd:25: <include
name="IDR_STATUS_TRAY_ICON_PRESSED"
file="google_chrome/product_logo_22_mono_invert.png" type="BINDATA" />
We'll need to remove the google_chrome assets as well before closing the bug.

https://codereview.chromium.org/464163003/diff/80001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/status_icons/status_icon_mac_unittest.mm (left):

https://codereview.chromium.org/464163003/diff/80001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/status_icons/status_icon_mac_unittest.mm:28:
icon->SetPressedImage(*pressed);
Should we remove SetPressedImage() entirely?

[Jitu( very slow this week), 2014-09-09 12:04:27]

@Andrew,

PTAL ...
I have removed all code related to SetPressedImage,

But don't understand why it is failing in Trybots for this
BookmarkBarControllerTest.TestDragButton Test.

Please help me in this.

[Andrew T Wilson (Slow), 2014-09-09 12:45:43]

lgtm, if you change the comment I mentioned.

I don't see any failing tests that look suspicious - I think it's just flaky
tests.

https://codereview.chromium.org/464163003/diff/140001/chrome/browser/status_i...
File chrome/browser/status_icons/status_icon_menu_model_unittest.cc (right):

https://codereview.chromium.org/464163003/diff/140001/chrome/browser/status_i...
chrome/browser/status_icons/status_icon_menu_model_unittest.cc:114: // Menu
state should have changed 8 times in this test.
update comment

[Jitu( very slow this week), 2014-09-09 14:09:20]

The CQ bit was checked by jitendra.ks@samsung.com

[commit-bot: I haz the power, 2014-09-09 14:10:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jitendra.ks@samsung.com/464163003/160001

[commit-bot: I haz the power, 2014-09-09 14:15:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-09 14:15:22]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Jitu( very slow this week), 2014-09-09 14:16:58]

Hi,

I am getting below error when submitting the patch, Please help me out in this.

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    chrome/app/theme/chrome_unscaled_resources.grd
    chrome/app/theme/chromium/product_logo_22_mono_invert.png
    chrome/browser/ui/cocoa/status_icons/status_icon_mac.h
    chrome/browser/ui/cocoa/status_icons/status_icon_mac.mm
    chrome/browser/ui/cocoa/status_icons/status_icon_mac_unittest.mm
    chrome/browser/ui/libgtk2ui/app_indicator_icon.cc
    chrome/browser/ui/libgtk2ui/app_indicator_icon.h
    chrome/browser/ui/libgtk2ui/gtk2_status_icon.cc
    chrome/browser/ui/libgtk2ui/gtk2_status_icon.h
    chrome/browser/ui/views/status_icons/status_icon_linux_wrapper.cc
    chrome/browser/ui/views/status_icons/status_icon_linux_wrapper.h
    chrome/browser/ui/views/status_icons/status_icon_win.cc
    chrome/browser/ui/views/status_icons/status_icon_win.h
    chrome/browser/ui/views/status_icons/status_tray_win_unittest.cc
    ui/views/linux_ui/status_icon_linux.h

[Bernhard Bauer, 2014-09-09 14:18:26]

On 2014/09/09 14:16:58, Jitu wrote:
> Hi,
> 
> I am getting below error when submitting the patch, Please help me out in
this.
> 
> ** Presubmit ERRORS **
> Missing LGTM from an OWNER for these files:
>     chrome/app/theme/chrome_unscaled_resources.grd
>     chrome/app/theme/chromium/product_logo_22_mono_invert.png
>     chrome/browser/ui/cocoa/status_icons/status_icon_mac.h
>     chrome/browser/ui/cocoa/status_icons/status_icon_mac.mm
>     chrome/browser/ui/cocoa/status_icons/status_icon_mac_unittest.mm
>     chrome/browser/ui/libgtk2ui/app_indicator_icon.cc
>     chrome/browser/ui/libgtk2ui/app_indicator_icon.h
>     chrome/browser/ui/libgtk2ui/gtk2_status_icon.cc
>     chrome/browser/ui/libgtk2ui/gtk2_status_icon.h
>     chrome/browser/ui/views/status_icons/status_icon_linux_wrapper.cc
>     chrome/browser/ui/views/status_icons/status_icon_linux_wrapper.h
>     chrome/browser/ui/views/status_icons/status_icon_win.cc
>     chrome/browser/ui/views/status_icons/status_icon_win.h
>     chrome/browser/ui/views/status_icons/status_tray_win_unittest.cc
>     ui/views/linux_ui/status_icon_linux.h

You will need to find OWNERS for these files. `git cl upload` should give you a
(somewhat randomly picked) suggestion, or take a look at the various OWNERS
files.

[Jitu( very slow this week), 2014-09-09 14:38:29]

jitendra.ks@samsung.com changed reviewers:
+ sky@chromium.org

[Jitu( very slow this week), 2014-09-09 14:39:02]

@Sky,

PTAL ...

[Jitu( very slow this week), 2014-09-10 03:30:56]

jitendra.ks@samsung.com changed reviewers:
+ ben@chromium.org

[Jitu( very slow this week), 2014-09-10 03:30:56]

Hi Ben and Sky,

PTAL...

This patch required owners approval.

[sky, 2014-09-10 14:39:59]

LGTM

[sky, 2014-09-10 14:40:15]

Update subject before landing, it is no longer WIP

[Jitu( very slow this week), 2014-09-11 05:23:33]

The CQ bit was checked by jitendra.ks@samsung.com

[commit-bot: I haz the power, 2014-09-11 05:25:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/464163003/160001

[commit-bot: I haz the power, 2014-09-11 05:36:08]

Committed patchset #9 (id:160001) as 2aefaa063d2a96a9a676a9bb040a9ebe890415f4

[commit-bot: I haz the power, 2014-09-11 05:40:13]

Patchset 9 (id:??) landed as
https://crrev.com/72d3e5c09036e3bebdf5d52081e70113e53b4331
Cr-Commit-Position: refs/heads/master@{#294324}