Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2266)

Unified Diff: Tools/GardeningServer/ui/test/ct-results-panel-tests.html

Issue 464163002: Sheriff-o-Matic: Convert some more ui tests to mocha (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/ui/test/ct-results-panel-tests.html
diff --git a/Tools/GardeningServer/ui/ct-results-panel-tests.html b/Tools/GardeningServer/ui/test/ct-results-panel-tests.html
similarity index 47%
rename from Tools/GardeningServer/ui/ct-results-panel-tests.html
rename to Tools/GardeningServer/ui/test/ct-results-panel-tests.html
index 37cd3a1b428ef8b31865eb335b484b56a43b1669..4529aec2ba9f8a609b1bbecf24acbc4e49798d2d 100644
--- a/Tools/GardeningServer/ui/ct-results-panel-tests.html
+++ b/Tools/GardeningServer/ui/test/ct-results-panel-tests.html
@@ -4,13 +4,15 @@ Use of this source code is governed by a BSD-style license that can be
found in the LICENSE file.
-->
-<link rel="import" href="ct-results-panel.html">
+<link rel="import" href="../ct-results-panel.html">
-<link rel="import" href="../model/ct-failure.html">
+<link rel="import" href="../../model/ct-failure.html">
<script>
(function () {
+var assert = chai.assert;
+
var kExampleFailures = [
new CTFailure("testName", "plugins/gesture-events-scrolled.html",
{
@@ -89,77 +91,85 @@ var kExampleFailures = [
),
];
-module("ct-results-panel");
-
-asyncTest("empty", 1, function() {
- var panel = document.createElement('ct-results-panel');
+describe('ct-results-panel', function() {
+ var panel;
+ var failures;
- requestAnimationFrame(function() {
- var message = panel.shadowRoot.querySelector('.message');
- equal(message.textContent, 'No results to display.');
+ beforeEach(function(done) {
+ panel = document.createElement('ct-results-panel');
+ if (failures)
+ panel.failures = failures;
- start();
+ setTimeout(done);
});
-});
-asyncTest("basic", 8, function() {
- var panel = document.createElement('ct-results-panel');
-
- panel.failures = kExampleFailures;
+ describe('empty', function() {
+ before(function() {
+ failures = undefined;
+ });
- requestAnimationFrame(function() {
- var items = panel.shadowRoot.querySelectorAll('paper-item');
- equal(items.length, 3);
- equal(items[0].label, 'plugins/gesture-events-scrolled.html');
- equal(items[1].label, 'plugins/transformed-events.html');
- equal(items[2].label, 'plugins/gesture-events.html');
+ it('should show no results', function() {
+ var message = panel.shadowRoot.querySelector('.message');
+ assert.equal(message.textContent, 'No results to display.');
+ });
+ });
- var results = panel.shadowRoot.querySelectorAll('ct-results-by-builder');
- equal(results.length, 1);
- equal(results[0].failure, kExampleFailures[0]);
+ describe('failing tests', function() {
+ before(function() {
+ failures = kExampleFailures;
+ });
- panel.shadowRoot.querySelector('core-menu').selected = 2;
+ it('should show tests and results for selected test', function(done) {
+ var items = panel.shadowRoot.querySelectorAll('paper-item');
+ assert.lengthOf(items, 3);
+ assert.equal(items[0].label, 'plugins/gesture-events-scrolled.html');
+ assert.equal(items[1].label, 'plugins/transformed-events.html');
+ assert.equal(items[2].label, 'plugins/gesture-events.html');
- requestAnimationFrame(function() {
var results = panel.shadowRoot.querySelectorAll('ct-results-by-builder');
- equal(results.length, 1);
- equal(results[0].failure, kExampleFailures[2]);
+ assert.lengthOf(results, 1);
+ assert.equal(results[0].failure, kExampleFailures[0]);
- start();
- });
- });
-});
+ panel.shadowRoot.querySelector('core-menu').selected = 2;
-asyncTest("whole step failed", 4, function() {
- var panel = document.createElement('ct-results-panel');
+ setTimeout(function() {
+ var results = panel.shadowRoot.querySelectorAll('ct-results-by-builder');
+ assert.lengthOf(results, 1);
+ assert.equal(results[0].failure, kExampleFailures[2]);
- var failure = {
- testName: null,
- step: 'foo-step',
- resultNodesByBuilder: {
- 'WebKit Win7 (dbg)': {
- actual: 'UNKNOWN',
- },
- },
- oldestFailingRevision: 123,
- newestPassingRevision: 124,
- };
-
- panel.failures = [failure];
+ done();
+ });
+ });
+ });
- requestAnimationFrame(function() {
- var items = panel.shadowRoot.querySelectorAll('paper-item');
- equal(items.length, 0);
+ describe('whole step failed', function() {
+ before(function() {
+ var failure = {
+ testName: null,
+ step: 'foo-step',
+ resultNodesByBuilder: {
+ 'WebKit Win7 (dbg)': {
+ actual: 'UNKNOWN',
+ },
+ },
+ oldestFailingRevision: 123,
+ newestPassingRevision: 124,
+ };
+ failures = [failure];
+ });
- var results = panel.shadowRoot.querySelectorAll('ct-results-by-builder');
- equal(results.length, 1);
- equal(results[0].failure, failure);
+ it('should show step failure', function() {
+ var items = panel.shadowRoot.querySelectorAll('paper-item');
+ assert.lengthOf(items, 0);
- equal(panel.shadowRoot.querySelectorAll('ct-embedded-flakiness-dashboard').length, 0);
+ var results = panel.shadowRoot.querySelectorAll('ct-results-by-builder');
+ assert.lengthOf(results, 1);
+ assert.equal(results[0].failure, failures[0]);
- start();
+ assert.lengthOf(panel.shadowRoot.querySelectorAll('ct-embedded-flakiness-dashboard'), 0);
+ });
});
});
-})()
+})();
</script>

Powered by Google App Engine
This is Rietveld 408576698