Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 464163002: Sheriff-o-Matic: Convert some more ui tests to mocha (Closed)

Created:
6 years, 4 months ago by michaelpg
Modified:
6 years, 4 months ago
Reviewers:
ojan
CC:
abarth-chromium, blink-reviews, Dirk Pranke, dsinclair, dstockwell, leviw_travelin_and_unemployed, szager1
Project:
blink
Visibility:
Public.

Description

Sheriff-o-Matic: Convert some more ui tests to mocha This converts the remaining ui test suites, besides the two that are currently failing (ct-failure-card, ct-failure-stream). BUG=400387 R=ojan@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180125

Patch Set 1 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+369 lines, -718 lines) Patch
M Tools/GardeningServer/karma.conf.js View 2 chunks +3 lines, -1 line 2 comments Download
M Tools/GardeningServer/run-unittests.html View 1 chunk +0 lines, -6 lines 0 comments Download
M Tools/GardeningServer/test/unit-tests.html View 1 chunk +6 lines, -0 lines 0 comments Download
D Tools/GardeningServer/ui/ct-embedded-flakiness-dashboard-tests.html View 1 chunk +0 lines, -46 lines 0 comments Download
D Tools/GardeningServer/ui/ct-results-comparison-zoomer-tests.html View 1 chunk +0 lines, -80 lines 0 comments Download
D Tools/GardeningServer/ui/ct-results-panel-tests.html View 1 chunk +0 lines, -165 lines 0 comments Download
D Tools/GardeningServer/ui/ct-revision-details-tests.html View 1 chunk +0 lines, -44 lines 0 comments Download
D Tools/GardeningServer/ui/ct-test-list-tests.html View 1 chunk +0 lines, -83 lines 0 comments Download
D Tools/GardeningServer/ui/ct-test-output-tests.html View 1 chunk +0 lines, -101 lines 0 comments Download
D Tools/GardeningServer/ui/ct-tree-status-tests.html View 1 chunk +0 lines, -45 lines 0 comments Download
A Tools/GardeningServer/ui/test/ct-results-comparison-zoomer-tests.html View 1 chunk +68 lines, -0 lines 0 comments Download
A + Tools/GardeningServer/ui/test/ct-results-panel-tests.html View 2 chunks +66 lines, -56 lines 0 comments Download
A + Tools/GardeningServer/ui/test/ct-revision-details-tests.html View 2 chunks +28 lines, -36 lines 0 comments Download
A + Tools/GardeningServer/ui/test/ct-test-list-tests.html View 1 chunk +50 lines, -55 lines 1 comment Download
A Tools/GardeningServer/ui/test/ct-test-output-tests.html View 1 chunk +103 lines, -0 lines 0 comments Download
A Tools/GardeningServer/ui/test/ct-tree-status-tests.html View 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
michaelpg
6 years, 4 months ago (2014-08-13 00:19:30 UTC) #1
ojan
The CQ bit was checked by ojan@chromium.org
6 years, 4 months ago (2014-08-13 00:30:27 UTC) #2
ojan
lgtm https://codereview.chromium.org/464163002/diff/40001/Tools/GardeningServer/karma.conf.js File Tools/GardeningServer/karma.conf.js (right): https://codereview.chromium.org/464163002/diff/40001/Tools/GardeningServer/karma.conf.js#newcode18 Tools/GardeningServer/karma.conf.js:18: checkLeaks: true, just curious, what does this do? ...
6 years, 4 months ago (2014-08-13 00:30:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/michaelpg@chromium.org/464163002/40001
6 years, 4 months ago (2014-08-13 00:32:21 UTC) #4
commit-bot: I haz the power
Change committed as 180125
6 years, 4 months ago (2014-08-13 00:37:28 UTC) #5
michaelpg
6 years, 4 months ago (2014-08-13 00:41:09 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/464163002/diff/40001/Tools/GardeningServer/ka...
File Tools/GardeningServer/karma.conf.js (right):

https://codereview.chromium.org/464163002/diff/40001/Tools/GardeningServer/ka...
Tools/GardeningServer/karma.conf.js:18: checkLeaks: true,
On 2014/08/13 00:30:28, ojan-only-code-yellow-reviews wrote:
> just curious, what does this do?

Checks for global variables being set (window.net is whitelisted below).

This is already being done in the browser unit tests but I noticed (when I
accidentally introduced a global in a test) that karma wasn't catching it.

Powered by Google App Engine
This is Rietveld 408576698