GN: Create a :gles2_interface target to resolve some check errors in //cc.

gpu/command_buffer/client/BUILD.gn

Index: gpu/command_buffer/client/BUILD.gn
diff --git a/gpu/command_buffer/client/BUILD.gn b/gpu/command_buffer/client/BUILD.gn
index d3e9b425900a57f97f795450bb99764a6ddd9e61..9972068c61d2e4439c37aca25e37ff63bd8c2f30 100644
--- a/gpu/command_buffer/client/BUILD.gn
+++ b/gpu/command_buffer/client/BUILD.gn
@@ -77,7 +77,6 @@ gles2_implementation_source_files = [
   "gles2_implementation.cc",
   "gles2_implementation.h",
   "gles2_implementation_impl_autogen.h",
-  "gles2_interface.h",
   "gles2_trace_implementation_autogen.h",
   "gles2_trace_implementation.cc",
   "gles2_trace_implementation.h",
@@ -95,6 +94,14 @@ gles2_implementation_source_files = [
   "vertex_array_object_manager.h",
 ]
 
+source_set("gles2_interface") {
+  sources = [ "gles2_interface.h" ]
+  all_dependent_configs = [ "//third_party/khronos:khronos_headers" ]

[jamesr, 2014/08/13 17:55:01]

can you make this direct_dependent_configs? not everything that lives downstream
of a target that uses GL should have the khronos include paths. if you have a
target that depends on gles2_interface and exposes #includes in its public
headers that need the khronos paths to work, use forward_dependent_configs_from
= [...] in that target

[jbroman, 2014/08/13 19:27:15]

There are a lot of other places that put this in all_dependent_configs, and
converting them all into direct_dependent_configs (with forwarding) seems like a
larger task.

How does "not making the problem any worse" (by using direct_dependent_configs
on this target, and leaving the existing ones for now) sound?

+  deps = [
+    "//base",
+  ]
+}
+
 # Library emulates GLES2 using command_buffers.
 component("gles2_implementation") {
   sources = gles2_implementation_source_files
@@ -109,6 +116,7 @@ component("gles2_implementation") {
 
   deps = [
     ":gles2_cmd_helper",
+    ":gles2_interface",
     "//base",
     "//gpu/command_buffer/common",
     "//ui/gfx/geometry",
@@ -133,6 +141,7 @@ component("gles2_implementation_client_side_arrays") {
 
   deps = [
     ":gles2_cmd_helper",
+    ":gles2_interface",
     "//base",
     "//gpu/command_buffer/common",
     "//ui/gfx/geometry",
@@ -171,6 +180,7 @@ component("gles2_c_lib") {
 
   deps = [
     ":client",
+    ":gles2_interface",
     "//base",
     "//base/third_party/dynamic_annotations",
     "//gpu/command_buffer/common",