Fix selection residue in sub-pixel positioned element

Fix selection residue in sub-pixel positioned element

We are inconsistent when invalidating and painting sub-pixel positioned
selections. See the bug for details.

This change add back the enclosingIntRect() calls that were removed in
http://src.chromium.org/viewvc/blink?view=rev&revision=177408. This is
needed before we fix the inconsistency.

BUG=394698
TEST=editing/selection/subpixel-positioned-selection.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180477

[Xianzhu, 2014-08-15 16:22:47]

ping...

[leviw_travelin_and_unemployed, 2014-08-15 19:02:23]

lgtm

https://codereview.chromium.org/464143003/diff/1/LayoutTests/TestExpectations
File LayoutTests/TestExpectations (right):

https://codereview.chromium.org/464143003/diff/1/LayoutTests/TestExpectations...
LayoutTests/TestExpectations:188: crbug.com/394698
fast/repaint/repaint-across-writing-mode-boundary.html [ NeedsRebaseline ]
What changes here?

[Xianzhu, 2014-08-15 19:06:57]

https://codereview.chromium.org/464143003/diff/1/LayoutTests/TestExpectations
File LayoutTests/TestExpectations (right):

https://codereview.chromium.org/464143003/diff/1/LayoutTests/TestExpectations...
LayoutTests/TestExpectations:188: crbug.com/394698
fast/repaint/repaint-across-writing-mode-boundary.html [ NeedsRebaseline ]
On 2014/08/15 19:02:23, leviw wrote:
> What changes here?

The repaint rect of selection is changed by 1 pixel.

[Xianzhu, 2014-08-15 19:07:00]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2014-08-15 19:07:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/464143003/1

[commit-bot: I haz the power, 2014-08-15 20:23:31]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/20001)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/22981)

[commit-bot: I haz the power, 2014-08-15 20:25:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-15 20:25:11]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/20007)

[Xianzhu, 2014-08-18 15:38:13]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2014-08-18 15:39:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/464143003/20001

[commit-bot: I haz the power, 2014-08-18 16:36:42]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/20234)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/23263)

[Xianzhu, 2014-08-18 16:44:50]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2014-08-18 16:44:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wangxianzhu@chromium.org/464143003/40001

[commit-bot: I haz the power, 2014-08-18 17:41:18]

Committed patchset #3 (40001) as 180477

[dglazkov, 2014-08-18 20:53:16]

On 2014/08/18 at 17:41:18, commit-bot wrote:
> Committed patchset #3 (40001) as 180477

I am pretty sure this failure is yours:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=@To...

Pls fix :)

[Xianzhu, 2014-08-18 21:09:43]

On 2014/08/18 20:53:16, dglazkov wrote:
> On 2014/08/18 at 17:41:18, commit-bot wrote:
> > Committed patchset #3 (40001) as 180477
> 
> I am pretty sure this failure is yours:
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=@To...
> 
> Pls fix :)

Done: https://codereview.chromium.org/482113002/