Switch my_activity.py to use gerrit_util for gerrit REST connections

my_activity.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Get stats about your activity.
 
 Example:
   - my_activity.py  for stats for the current week (last week on mondays).
   - my_activity.py -Q  for stats for last quarter.
@@ skipping 17 matching lines @@
 from functools import partial
 import json
 import optparse
 import os
 import re
 import subprocess
 import sys
 import urllib
 import urllib2
 
+import gerrit_util
 import rietveld
 from third_party import upload
 
 # Imported later, once options are set.
 webkitpy = None
 
 try:
   from dateutil.relativedelta import relativedelta # pylint: disable=F0401
 except ImportError:
   print 'python-dateutil package required'
@@ skipping 64 matching lines @@
     'requires_auth': False,
     'email_domain': 'chromium.org',
   },
 ]
 
 gerrit_instances = [
   {
     'url': 'chromium-review.googlesource.com',
     'shorturl': 'crosreview.com',
   },
-  # TODO(deymo): chrome-internal-review requires login credentials. Enable once
-  # login support is added to this client. See crbug.com/281695.
-  #{
-  #  'url': 'chrome-internal-review.googlesource.com',
-  #  'shorturl': 'crosreview.com/i',
-  #},
+  {
+    'url': 'chrome-internal-review.googlesource.com',
+    'shorturl': 'crosreview.com/i',
+  },
   {
     'host': 'gerrit.chromium.org',
     'port': 29418,
   },
   {
     'host': 'gerrit-int.chromium.org',
     'port': 29419,
   },
 ]
 
@@ skipping 259 matching lines @@
                   '--format', 'JSON',
                   '--comments',
                   '--'] + filters
     (stdout, _) = subprocess.Popen(gquery_cmd, stdout=subprocess.PIPE,
                                    stderr=subprocess.PIPE).communicate()
     # Drop the last line of the output with the stats.
     issues = stdout.splitlines()[:-1]
     return map(json.loads, issues)
 
   @staticmethod
   def gerrit_changes_over_rest(instance, filters):

[deymo, 2013/10/30 21:36:33]

I think the same functionality implemented in this function can be achieved with
gerrit_util.QueryChanges() as I did in this patch:
https://codereview.chromium.org/50283002/diff/50001/my_activity.py

(the patch also includes the fix for bug 311649 using the QueryAllChanges()
function).

     # See https://gerrit-review.googlesource.com/Documentation/rest-api.html
     # Gerrit doesn't allow filtering by created time, only modified time.
     args = urllib.urlencode([
         ('q', ' '.join(filters)),
         ('o', 'MESSAGES'),
         ('o', 'LABELS')])
-    rest_url = 'https://%s/changes/?%s' % (instance['url'], args)
+    conn = gerrit_util.CreateHttpConn(instance['url'], 'changes/?%s' % args)
 
-    req = urllib2.Request(rest_url, headers={'Accept': 'text/plain'})
     try:
-      response = urllib2.urlopen(req)
+      response = gerrit_util.ReadHttpResponse(conn, ignore_404=False)
       stdout = response.read()
-    except urllib2.HTTPError, e:
-      print 'ERROR: Looking up %r: %s' % (rest_url, e)
+    except gerrit_util.GerritError, e:
+      print 'ERROR: Looking up %r: %s' % (instance['url'], e)
       return []
 
     # Check that the returned JSON starts with the right marker.
     if stdout[:5] != ")]}'\n":
       print 'ERROR: Marker not found on REST API response: %r' % stdout[:5]
       return []
     return json.loads(stdout[5:])
 
   def gerrit_search(self, instance, owner=None, reviewer=None):
     max_age = datetime.today() - self.modified_after
@@ skipping 673 matching lines @@
   print '\n\n\n'
 
   my_activity.print_changes()
   my_activity.print_reviews()
   my_activity.print_issues()
   return 0
 
 
 if __name__ == '__main__':
   sys.exit(main())