Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 46413002: Switch my_activity.py to use gerrit_util for gerrit REST connections (Closed)

Created:
7 years, 1 month ago by Ryan Tseng
Modified:
7 years, 1 month ago
Reviewers:
deymo, szager
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Switch my_activity.py to use gerrit_util for gerrit REST connections Also added changes in gerrit_util.py to: * Pick up the chrome-internal auth when chrome-internal-review is passed in, since in reality they share the same auth. * Not use the /a/ endpoint if no auth is found in the netrc, so that chromium-reviews.googlesource.com will still work without a netrc auth. BUG=281695

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -12 lines) Patch
M gerrit_util.py View 2 chunks +9 lines, -1 line 0 comments Download
M my_activity.py View 3 chunks +9 lines, -11 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
Ryan Tseng
+Szager: Can you take a look at this?
7 years, 1 month ago (2013-10-26 00:22:16 UTC) #1
deymo
I'm fine with this change (although I don't really understand why are the changes to ...
7 years, 1 month ago (2013-10-30 21:36:33 UTC) #2
Ryan Tseng
7 years, 1 month ago (2013-10-30 22:19:46 UTC) #3

Powered by Google App Engine
This is Rietveld 408576698