Issue 464093002: ES6: Make Map/Set constructors support iterable values

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 464093002: ES6: Make Map/Set constructors support iterable values (Closed)

Created:
6 years, 4 months ago by arv (Not doing code reviews)

Modified:
6 years, 4 months ago

Reviewers:
Dmitry Lomov (no reviews), adamk

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

ES6: Make Map/Set constructors support iterable values Same for WeakMap/WeakSet https://bugs.ecmascript.org/show_bug.cgi?id=3111 The change from the reverted version is that LoadIC_Miss now uses Name instead of String. BUG=v8:3508 LOG=Y R=adamk@chromium.org, dslomov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23108

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+68 lines, -5 lines)			Patch
M	src/collection.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/ic.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/weak_collection.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	test/mjsunit/es6/collections.js	View	4 chunks	+63 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

adamk

lgtm; seems like we might want to cherry-pick this whole thing into whatever ends up ...

6 years, 4 months ago (2014-08-12 23:39:36 UTC) #2

arv (Not doing code reviews)

6 years, 4 months ago (2014-08-13 14:34:20 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as 23108 (presubmit successful).