Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1039)

Issue 464073003: Battery Status API: manual webpage test. (Closed)

Created:
6 years, 4 months ago by timvolodine
Modified:
6 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Battery Status API: manual webpage test. This patch contains a test page used for manually checking the functionality of the Battery Status API. It is currently also available at http://jsbin.com/battery-status-test. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291203

Patch Set 1 #

Total comments: 2

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -0 lines) Patch
A content/test/data/battery_status/battery_status_manual_test.html View 1 1 chunk +89 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
timvolodine
6 years, 4 months ago (2014-08-18 15:22:37 UTC) #1
Michael van Ouwerkerk
lgtm with nit https://codereview.chromium.org/464073003/diff/1/content/test/data/battery_status/battery_status_manual_test.html File content/test/data/battery_status/battery_status_manual_test.html (right): https://codereview.chromium.org/464073003/diff/1/content/test/data/battery_status/battery_status_manual_test.html#newcode57 content/test/data/battery_status/battery_status_manual_test.html:57: battery.addEventListener('chargingchange', function() { I think none ...
6 years, 4 months ago (2014-08-18 15:46:06 UTC) #2
timvolodine
thanks! https://codereview.chromium.org/464073003/diff/1/content/test/data/battery_status/battery_status_manual_test.html File content/test/data/battery_status/battery_status_manual_test.html (right): https://codereview.chromium.org/464073003/diff/1/content/test/data/battery_status/battery_status_manual_test.html#newcode57 content/test/data/battery_status/battery_status_manual_test.html:57: battery.addEventListener('chargingchange', function() { On 2014/08/18 15:46:06, Michael van ...
6 years, 4 months ago (2014-08-20 11:28:03 UTC) #3
timvolodine
The CQ bit was checked by timvolodine@chromium.org
6 years, 4 months ago (2014-08-21 14:52:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timvolodine@chromium.org/464073003/20001
6 years, 4 months ago (2014-08-21 14:53:25 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 21:48:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (20001) as 291203

Powered by Google App Engine
This is Rietveld 408576698