Chromium Code Reviews| Index: Source/modules/geofencing/CircularRegion.cpp |
| diff --git a/Source/modules/geofencing/CircularRegion.cpp b/Source/modules/geofencing/CircularRegion.cpp |
| index 2007e46b6e185231e4cab6fd175bd56c0e01fd59..4b2005ba39eafe65bffbd7e08b8d4ff6316b1e77 100644 |
| --- a/Source/modules/geofencing/CircularRegion.cpp |
| +++ b/Source/modules/geofencing/CircularRegion.cpp |
| @@ -6,6 +6,8 @@ |
| #include "modules/geofencing/CircularRegion.h" |
| #include "bindings/core/v8/Dictionary.h" |
| +#include "public/platform/WebCircularRegion.h" |
| +#include "public/platform/WebString.h" |
| namespace blink { |
| @@ -22,16 +24,29 @@ CircularRegionInit::CircularRegionInit(const Dictionary& init) |
| CircularRegion* CircularRegion::create(const Dictionary& init) |
| { |
| - return new CircularRegion(CircularRegionInit(init)); |
| + CircularRegionInit rinit(init); |
|
abarth-chromium
2014/08/23 05:43:34
rinit -> please use complete words in variable nam
Marijn Kruisselbrink
2014/08/25 22:25:25
Done.
|
| + return new CircularRegion(WebCircularRegion::create(rinit.id, rinit.latitude, rinit.longitude, rinit.radius)); |
|
abarth-chromium
2014/08/23 05:43:34
So much mallocing. Can't WebCircularRegion just b
|
| } |
| -CircularRegion::CircularRegion(const CircularRegionInit& init) |
| - : GeofencingRegion(init.id) |
| - , m_latitude(init.latitude) |
| - , m_longitude(init.longitude) |
| - , m_radius(init.radius) |
| +CircularRegion::CircularRegion(const WebCircularRegion& region) |
| + : GeofencingRegion(region) |
| { |
| ScriptWrappable::init(this); |
| } |
| +double CircularRegion::latitude() const |
| +{ |
| + return webRegion().toConst<WebCircularRegion>().latitude(); |
|
abarth-chromium
2014/08/23 05:43:34
So ugly...
Why not just have WebCircularRegion be
|
| +} |
| + |
| +double CircularRegion::longitude() const |
| +{ |
| + return webRegion().toConst<WebCircularRegion>().longitude(); |
| +} |
| + |
| +double CircularRegion::radius() const |
| +{ |
| + return webRegion().toConst<WebCircularRegion>().radius(); |
| +} |
| + |
| } // namespace blink |