Add a flag to enable remote CoreAnimation API.

Add a flag to enable remote CoreAnimation API.

A follow-on patch will switch this flag to be enabled by default.

BUG=312462
TBR=kbr
R=sky

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289835

[ccameron, 2014-08-14 00:00:52]

This is part 1 of 2 (this one goes in before the branch, the other bit comes in
after the branch).

[sky, 2014-08-14 00:19:09]

https://codereview.chromium.org/464063005/diff/1/ui/base/cocoa/remote_layer_a...
File ui/base/cocoa/remote_layer_api.mm (right):

https://codereview.chromium.org/464063005/diff/1/ui/base/cocoa/remote_layer_a...
ui/base/cocoa/remote_layer_api.mm:15: static bool enabled_at_command_line =
Unless there is really a reason to make this static I wouldn't. Otherwise unit
tests may be tricky.

https://codereview.chromium.org/464063005/diff/1/ui/base/ui_base_switches.h
File ui/base/ui_base_switches.h (right):

https://codereview.chromium.org/464063005/diff/1/ui/base/ui_base_switches.h#n...
ui/base/ui_base_switches.h:16: UI_BASE_EXPORT extern const char
kEnableRemoteCoreAnimation[];
nit: try to sort these.

[ccameron, 2014-08-14 00:33:32]

Thanks!

https://codereview.chromium.org/464063005/diff/1/ui/base/cocoa/remote_layer_a...
File ui/base/cocoa/remote_layer_api.mm (right):

https://codereview.chromium.org/464063005/diff/1/ui/base/cocoa/remote_layer_a...
ui/base/cocoa/remote_layer_api.mm:15: static bool enabled_at_command_line =
On 2014/08/14 00:19:08, sky wrote:
> Unless there is really a reason to make this static I wouldn't. Otherwise unit
> tests may be tricky.

Done.

https://codereview.chromium.org/464063005/diff/1/ui/base/ui_base_switches.h
File ui/base/ui_base_switches.h (right):

https://codereview.chromium.org/464063005/diff/1/ui/base/ui_base_switches.h#n...
ui/base/ui_base_switches.h:16: UI_BASE_EXPORT extern const char
kEnableRemoteCoreAnimation[];
On 2014/08/14 00:19:08, sky wrote:
> nit: try to sort these.

Done.

[sky, 2014-08-14 16:41:31]

LGTM

[ccameron, 2014-08-14 17:50:44]

Thanks! TRBing kbr cause of SIGGRAPH

[ccameron, 2014-08-14 17:51:10]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2014-08-14 17:52:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ccameron@chromium.org/464063005/20001

[commit-bot: I haz the power, 2014-08-15 07:51:36]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)

[commit-bot: I haz the power, 2014-08-15 09:41:20]

Committed patchset #2 (20001) as 289835

[Ken Russell (switch to Gerrit), 2014-08-15 20:53:49]

LGTM after the fact.