Added linux_asan tests to chromium_memory_trybot

Added linux_asan tests to chromium_memory_trybot

This is the Chromium side of the change to convert the linux_asan
builder to a recipe.

BUG=399729
Committed: https://crrev.com/5f5d505e02d5fedada7adf5189b2d57c3da7f403
Cr-Commit-Position: refs/heads/master@{#291727}

[cmumford, 2014-08-13 17:14:00]

For a bit more context see https://codereview.chromium.org/449993005/

[Paweł Hajdan Jr., 2014-08-14 11:23:38]

https://codereview.chromium.org/464063004/diff/1/testing/buildbot/chromium_me...
File testing/buildbot/chromium_memory_trybot.json (right):

https://codereview.chromium.org/464063004/diff/1/testing/buildbot/chromium_me...
testing/buildbot/chromium_memory_trybot.json:10: "can_use_on_swarming_builders":
true
Are we using this on swarming for memory tools? If not, please disable this,
here and everywhere else in this file.

https://codereview.chromium.org/464063004/diff/1/testing/buildbot/chromium_me...
testing/buildbot/chromium_memory_trybot.json:63:
"gtest_tests_filter_exclusions": [
This shouldn't be duplicated. Can we leave it out for now and figure out a
better solution that would prevent duplication?

https://codereview.chromium.org/464063004/diff/1/testing/buildbot/chromium_me...
testing/buildbot/chromium_memory_trybot.json:85: "filter_tests_builders": [
Same here, looks like this is just not relevant to the memory trybots for now.

[cmumford, 2014-08-14 18:32:15]

OK, I've made the changes, but also since this CL landed this file was also
added in another CL (crrev.com/471963002). Will this change add 27 new tests to
linux_browser_asan, and three new ones to linux_asan?

Or should this be a new file?

https://codereview.chromium.org/464063004/diff/1/testing/buildbot/chromium_me...
File testing/buildbot/chromium_memory_trybot.json (right):

https://codereview.chromium.org/464063004/diff/1/testing/buildbot/chromium_me...
testing/buildbot/chromium_memory_trybot.json:10: "can_use_on_swarming_builders":
true
On 2014/08/14 11:23:38, Paweł Hajdan Jr. wrote:
> Are we using this on swarming for memory tools? If not, please disable this,
> here and everywhere else in this file.

Done.

https://codereview.chromium.org/464063004/diff/1/testing/buildbot/chromium_me...
testing/buildbot/chromium_memory_trybot.json:63:
"gtest_tests_filter_exclusions": [
On 2014/08/14 11:23:38, Paweł Hajdan Jr. wrote:
> This shouldn't be duplicated. Can we leave it out for now and figure out a
> better solution that would prevent duplication?

Done.

https://codereview.chromium.org/464063004/diff/1/testing/buildbot/chromium_me...
testing/buildbot/chromium_memory_trybot.json:85: "filter_tests_builders": [
On 2014/08/14 11:23:38, Paweł Hajdan Jr. wrote:
> Same here, looks like this is just not relevant to the memory trybots for now.

Done.

[Paweł Hajdan Jr., 2014-08-15 11:29:28]

Please exclude the tests from bots they should not run on, see
chromium_trybot.json for syntax examples.

[cmumford, 2014-08-18 17:09:17]

On 2014/08/15 11:29:28, Paweł Hajdan Jr. wrote:
> Please exclude the tests from bots they should not run on, see
> chromium_trybot.json for syntax examples.

Done. I think it's only two tests which are Linux only.

[cmumford, 2014-08-18 17:24:31]

On 2014/08/18 17:09:17, cmumford wrote:
> On 2014/08/15 11:29:28, Paweł Hajdan Jr. wrote:
> > Please exclude the tests from bots they should not run on, see
> > chromium_trybot.json for syntax examples.
> 
> Done. I think it's only two tests which are Linux only.

Pawel: Also, it still looks to me as though if this were to land then the
linux_browser_asan builder would start running all of these tests. Should these
instead be in a different spec file?

[Paweł Hajdan Jr., 2014-08-19 13:27:10]

On 2014/08/18 17:24:31, cmumford wrote:
> Pawel: Also, it still looks to me as though if this were to land then the
> linux_browser_asan builder would start running all of these tests. Should
these
> instead be in a different spec file?

IMHO they should be in the same spec file - in fact there are plans to merge the
bots: https://code.google.com/p/chromium/issues/detail?id=404694

For now exclude them from specific bots.

[cmumford, 2014-08-19 16:03:54]

On 2014/08/19 13:27:10, Paweł Hajdan Jr. wrote:
> On 2014/08/18 17:24:31, cmumford wrote:
> > Pawel: Also, it still looks to me as though if this were to land then the
> > linux_browser_asan builder would start running all of these tests. Should
> these
> > instead be in a different spec file?
> 
> IMHO they should be in the same spec file - in fact there are plans to merge
the
> bots: https://code.google.com/p/chromium/issues/detail?id=404694
> 
> For now exclude them from specific bots.

Is my recent change what you meant by excluding from different bots. I didn't
see another way to do this. However, I believe that in order for this to land a
corresponding change in the build project must also land? Or is there a better
way to exclude?

[Paweł Hajdan Jr., 2014-08-20 10:57:43]

I don't think the format in Patch Set 4 is valid. Does it work for you locally?

Please use exclude_builders instead, see should_use_test in chromium_trybot.py .
Feel free to upload a CL to improve the recipe-side code.

[Paweł Hajdan Jr., 2014-08-25 17:35:34]

LGTM

[cmumford, 2014-08-25 17:45:01]

The CQ bit was checked by cmumford@chromium.org

[commit-bot: I haz the power, 2014-08-25 17:46:35]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/cmumford@chromium.org/464063004/80001

[commit-bot: I haz the power, 2014-08-25 18:57:49]

Committed patchset #5 (80001) as 70f462d59346156b418b2b98dcaf42efe5d52a4c

[commit-bot: I haz the power, 2014-09-10 02:36:21]

Patchset 5 (id:??) landed as
https://crrev.com/5f5d505e02d5fedada7adf5189b2d57c3da7f403
Cr-Commit-Position: refs/heads/master@{#291727}