Issue 464053: Fixing up test expectations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 464053: Fixing up test expectations (Closed)

Created:
11 years ago by scherkus (not reviewing)

Modified:
9 years, 7 months ago

Reviewers:
awong

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Commenting out a test that doesn't exist and mark video-transformed as image flaky on linux. BUG=13907 TEST=more green please! TBR=ajwong Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33913

Patch Set 1 #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	webkit/tools/layout_tests/test_expectations.txt	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

awong

11 years ago (2009-12-05 02:26:53 UTC) #2

LGTM

On Fri, Dec 4, 2009 at 6:16 PM, <scherkus@chromium.org> wrote:

> Reviewers: awong,
>
> Description:
> Marking video-transformed as image flaky on linux.
>
> BUG=13907
> TEST=more green please!
> TBR=ajwong
>
> Please review this at http://codereview.chromium.org/464053
>
> Affected files:
>  M webkit/tools/layout_tests/test_expectations.txt
>
>
> Index: webkit/tools/layout_tests/test_expectations.txt
> diff --git a/webkit/tools/layout_tests/test_expectations.txt
> b/webkit/tools/layout_tests/test_expectations.txt
> index
>
3b00f3b69e51f67d5256788f061cc8b120a25d1e..d9523415b61999c930002b613d3b8ea77b06eb8b
> 100644
> --- a/webkit/tools/layout_tests/test_expectations.txt
> +++ b/webkit/tools/layout_tests/test_expectations.txt
> @@ -784,7 +784,7 @@ BUG13907 BUG25376 MAC DEBUG :
> LayoutTests/media/video-empty-source.html = FAIL
>  BUG13907 : LayoutTests/media/controls-styling.html = FAIL
>
>  // These tests are flaky with subtle pixel differences.
> -BUG9798 BUG13907 MAC : LayoutTests/media/video-transformed.html = IMAGE
> PASS
> +BUG9798 BUG13907 LINUX MAC : LayoutTests/media/video-transformed.html =
> IMAGE PASS
>  BUG9798 BUG13907 MAC : LayoutTests/media/video-layer-crash.html = IMAGE
> PASS
>
>  // These tests are failing because they use position-dependent mouse
> clicks.
>
>
>

Expand Messages | Collapse Messages