Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1941)

Unified Diff: Source/modules/InitModules.cpp

Issue 464043002: Refactor module initialization. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removed one-line functions and added isInitialized Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« Source/modules/InitModules.h ('K') | « Source/modules/InitModules.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/InitModules.cpp
diff --git a/Source/modules/InitModules.cpp b/Source/modules/InitModules.cpp
index b1b14e6a5fcb33e5b9580f7c24e04550a86839ec..a93c0161ad729789d60f88b30d41bc91271b0f78 100644
--- a/Source/modules/InitModules.cpp
+++ b/Source/modules/InitModules.cpp
@@ -14,27 +14,19 @@
namespace blink {
-void ModulesInitializer::initEventNames()
+void ModulesInitializer::init()
{
- EventNames::init();
- EventNames::initModules();
-}
+ ASSERT(!isInitialized());
-void ModulesInitializer::initEventTargetNames()
-{
- EventTargetNames::init();
+ // Strings must be initialized before calling CoreInitializer::init().
+ EventNames::initModules();
EventTargetNames::initModules();
-}
-
-void ModulesInitializer::registerEventFactory()
-{
- CoreInitializer::registerEventFactory();
Document::registerEventFactory(EventModulesFactory::create());
-}
-
-void ModulesInitializer::initBindings()
-{
ModuleBindingsInitializer::init();
+
+ CoreInitializer::init();
+
+ ASSERT(isInitialized());
}
} // namespace blink
« Source/modules/InitModules.h ('K') | « Source/modules/InitModules.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698