Issue 464043: Reverts r4177, reimplements a fix for bug 3417. Adding UpdateObservers to Dow...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 464043: Reverts r4177, reimplements a fix for bug 3417. Adding UpdateObservers to Dow... (Closed)

Created:
11 years ago by Avi (use Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com, Paul Godavari, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Reverts r4177, reimplements a fix for bug 3417. Adding UpdateObservers to DownloadItem::Finished is wrong, as it causes a duplicate notification to fire when a download is complete. BUG=http://crbug.com/3417 TEST=bug does not regress Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=33848

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	chrome/browser/download/download_manager.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	chrome/browser/download/save_package.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

El Gee.

Expand Messages | Collapse Messages