Refactor building of lazy bailouts in AstGraphBuilder.

src/compiler/ast-graph-builder.h

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_COMPILER_AST_GRAPH_BUILDER_H_
 #define V8_COMPILER_AST_GRAPH_BUILDER_H_
 
 #include "src/v8.h"
 
 #include "src/ast.h"
@@ skipping 153 matching lines @@
   void VisitNot(UnaryOperation* expr);
 
   // Dispatched from VisitBinaryOperation.
   void VisitComma(BinaryOperation* expr);
   void VisitLogicalExpression(BinaryOperation* expr);
   void VisitArithmeticExpression(BinaryOperation* expr);
 
   // Dispatched from VisitForInStatement.
   void VisitForInAssignment(Expression* expr, Node* value);
 
-  void BuildLazyBailout(Node* node, BailoutId ast_id);
-  void BuildLazyBailoutWithPushedNode(Node* node, BailoutId ast_id);
+  enum OutputFrameStateCombine { PUSH_OUTPUT, IGNORE_OUTPUT };

[Michael Starzinger, 2014/08/12 21:17:40]

nit: Can we add a comment describing the semantics behind this enum?

+
+  void BuildLazyBailout(Node* node, BailoutId ast_id,

[Michael Starzinger, 2014/08/12 21:17:41]

nit: Since the BuildFoo methods all have a clear semantic (see comment above in
line 69), how would you feel about naming this AttachLazyBailout or
PrepareLazyBailout instead?

+                        OutputFrameStateCombine combine = IGNORE_OUTPUT);

[Michael Starzinger, 2014/08/12 21:27:40]

nit: Also, there seems to be no caller relying on the default argument. Can we
drop the default argument?

+  OutputFrameStateCombine StateCombineFromAstContext();

[Michael Starzinger, 2014/08/12 21:17:40]

suggestion: I would be fine with moving this into AstContext so that one could
call "ast_context()->GetStateCombine()" instead (if that still makes all of them
fit into one line ^^).

 
   DEFINE_AST_VISITOR_SUBCLASS_MEMBERS();
   DISALLOW_COPY_AND_ASSIGN(AstGraphBuilder);
 };
 
 
 // The abstract execution environment for generated code consists of
 // parameter variables, local variables and the operand stack. The
 // environment will perform proper SSA-renaming of all tracked nodes
 // at split and merge points in the control flow. Internally all the
@@ skipping 92 matching lines @@
 // decides how the evaluation result is passed up the visitor.
 class AstGraphBuilder::AstContext BASE_EMBEDDED {
  public:
   bool IsEffect() const { return kind_ == Expression::kEffect; }
   bool IsValue() const { return kind_ == Expression::kValue; }
   bool IsTest() const { return kind_ == Expression::kTest; }
 
   // Plug a node into this expression context.  Call this function in tail
   // position in the Visit functions for expressions.
   virtual void ProduceValue(Node* value) = 0;
-  virtual void ProduceValueWithLazyBailout(Node* value) = 0;
 
   // Unplugs a node from this expression context.  Call this to retrieve the
   // result of another Visit function that already plugged the context.
   virtual Node* ConsumeValue() = 0;
 
   // Shortcut for "context->ProduceValue(context->ConsumeValue())".
   void ReplaceValue() { ProduceValue(ConsumeValue()); }
 
  protected:
-  AstContext(AstGraphBuilder* owner, Expression::Context kind,
-             BailoutId bailout_id);
+  AstContext(AstGraphBuilder* owner, Expression::Context kind);
   virtual ~AstContext();
 
   AstGraphBuilder* owner() const { return owner_; }
   Environment* environment() const { return owner_->environment(); }
 
 // We want to be able to assert, in a context-specific way, that the stack
 // height makes sense when the context is filled.
 #ifdef DEBUG
   int original_height_;
 #endif
 
-  BailoutId bailout_id_;
-
  private:
   Expression::Context kind_;
   AstGraphBuilder* owner_;
   AstContext* outer_;
 };
 
 
 // Context to evaluate expression for its side effects only.
 class AstGraphBuilder::AstEffectContext V8_FINAL : public AstContext {
  public:
-  explicit AstEffectContext(AstGraphBuilder* owner, BailoutId bailout_id)
-      : AstContext(owner, Expression::kEffect, bailout_id) {}
+  explicit AstEffectContext(AstGraphBuilder* owner)
+      : AstContext(owner, Expression::kEffect) {}
   virtual ~AstEffectContext();
   virtual void ProduceValue(Node* value) V8_OVERRIDE;
-  virtual void ProduceValueWithLazyBailout(Node* value) V8_OVERRIDE;
   virtual Node* ConsumeValue() V8_OVERRIDE;
 };
 
 
 // Context to evaluate expression for its value (and side effects).
 class AstGraphBuilder::AstValueContext V8_FINAL : public AstContext {
  public:
-  explicit AstValueContext(AstGraphBuilder* owner, BailoutId bailout_id)
-      : AstContext(owner, Expression::kValue, bailout_id) {}
+  explicit AstValueContext(AstGraphBuilder* owner)
+      : AstContext(owner, Expression::kValue) {}
   virtual ~AstValueContext();
   virtual void ProduceValue(Node* value) V8_OVERRIDE;
-  virtual void ProduceValueWithLazyBailout(Node* value) V8_OVERRIDE;
   virtual Node* ConsumeValue() V8_OVERRIDE;
 };
 
 
 // Context to evaluate expression for a condition value (and side effects).
 class AstGraphBuilder::AstTestContext V8_FINAL : public AstContext {
  public:
-  explicit AstTestContext(AstGraphBuilder* owner, BailoutId bailout_id)
-      : AstContext(owner, Expression::kTest, bailout_id) {}
+  explicit AstTestContext(AstGraphBuilder* owner)
+      : AstContext(owner, Expression::kTest) {}
   virtual ~AstTestContext();
   virtual void ProduceValue(Node* value) V8_OVERRIDE;
-  virtual void ProduceValueWithLazyBailout(Node* value) V8_OVERRIDE;
   virtual Node* ConsumeValue() V8_OVERRIDE;
 };
 
 
 // Scoped class tracking breakable statements entered by the visitor. Allows to
 // properly 'break' and 'continue' iteration statements as well as to 'break'
 // from blocks within switch statements.
 class AstGraphBuilder::BreakableScope BASE_EMBEDDED {
  public:
   BreakableScope(AstGraphBuilder* owner, BreakableStatement* target,
@@ skipping 57 matching lines @@
 };
 
 Scope* AstGraphBuilder::current_scope() const {
   return execution_context_->scope();
 }
 }
 }
 }  // namespace v8::internal::compiler
 
 #endif  // V8_COMPILER_AST_GRAPH_BUILDER_H_