chrome/browser/ui/browser_browsertest.cc - Issue 46403006: Prevent a browser crash if dialogs are shown when navigating away.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_browsertest.cc

Issue 46403006: Prevent a browser crash if dialogs are shown when navigating away. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/browser_browsertest.cc

diff --git a/chrome/browser/ui/browser_browsertest.cc b/chrome/browser/ui/browser_browsertest.cc

index c4f0a0eda571f15dcf02f685574425c31652d7c6..2e5d76f2e08fb1795736780f6345acc6f5da580e 100644

--- a/chrome/browser/ui/browser_browsertest.cc

+++ b/chrome/browser/ui/browser_browsertest.cc

@@ -471,6 +471,9 @@ IN_PROC_BROWSER_TEST_F(BrowserTest, CrossProcessNavCancelsDialogs) {

GURL url(test_server()->GetURL("empty.html"));

ui_test_utils::NavigateToURL(browser(), url);

+ // TODO(creis): Test this with a setInterval loop of alert dialogs to ensure

+ // that we can navigate away even if the renderer tries to synchronously

+ // create more. See http://crbug.com/312490.

WebContents* contents = browser()->tab_strip_model()->GetActiveWebContents();

contents->GetRenderViewHost()->ExecuteJavascriptInWebFrame(

string16(),