Prevent a browser crash if dialogs are shown when navigating away.

Prevent a browser crash if dialogs are shown when navigating away.

BUG=312046
TEST=See bug.
R=darin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=231587

[Charlie Reis, 2013-10-29 00:14:13]

Darin, can you take a look?  The nested message loop issue makes the underlying
bug tricky, so I'm hoping to prevent the browser crash first in a way that's
easy to merge, then follow it up with the larger proposed fix for
http://crbug.com/312490.

[Charlie Reis, 2013-10-29 00:16:26]

On 2013/10/29 00:14:13, creis wrote:
> Darin, can you take a look?  The nested message loop issue makes the
underlying
> bug tricky, so I'm hoping to prevent the browser crash first in a way that's
> easy to merge, then follow it up with the larger proposed fix for
> http://crbug.com/312490.

For reference, this augments the fix in
https://codereview.chromium.org/25434002, where we called
CancelModalDialogsForRenderManager() in SwapOutOldPage.  That works as long as
there's only one dialog, but the renderer could immediately create another
dialog.  In that case, we delete the RVH just before running the callback that
references it.  In the short term, this CL makes sure that we cancel the current
dialog immediately before deleting the RVH.

[darin (slow to review), 2013-10-29 16:57:23]

LGTM

https://codereview.chromium.org/46403006/diff/1/content/browser/web_contents/...
File content/browser/web_contents/render_view_host_manager.cc (right):

https://codereview.chromium.org/46403006/diff/1/content/browser/web_contents/...
content/browser/web_contents/render_view_host_manager.cc:765: // created another
in the mean time.)  Make sure we run and reset the callback
nit: "mean time" -> "meantime"

[Charlie Reis, 2013-10-29 17:13:17]

https://codereview.chromium.org/46403006/diff/1/content/browser/web_contents/...
File content/browser/web_contents/render_view_host_manager.cc (right):

https://codereview.chromium.org/46403006/diff/1/content/browser/web_contents/...
content/browser/web_contents/render_view_host_manager.cc:765: // created another
in the mean time.)  Make sure we run and reset the callback
On 2013/10/29 16:57:23, darin wrote:
> nit: "mean time" -> "meantime"

Done.

[Charlie Reis, 2013-10-29 17:14:18]

Committed patchset #3 manually as r231587 (presubmit successful).