Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1028)

Unified Diff: components/data_reduction_proxy/browser/data_reduction_proxy_params_unittest.cc

Issue 464023002: Fixed DataReductionProxyParams::AreProxiesBypassed logic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Switching logic back Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/browser/data_reduction_proxy_params_unittest.cc
diff --git a/components/data_reduction_proxy/browser/data_reduction_proxy_params_unittest.cc b/components/data_reduction_proxy/browser/data_reduction_proxy_params_unittest.cc
index 69a9ab6171135c7d398b1c02013e312aa0e75ccd..9a5681d1594263df450a2709de4044975cf6206d 100644
--- a/components/data_reduction_proxy/browser/data_reduction_proxy_params_unittest.cc
+++ b/components/data_reduction_proxy/browser/data_reduction_proxy_params_unittest.cc
@@ -704,7 +704,7 @@ TEST_F(DataReductionProxyParamsTest, AreProxiesBypassed) {
{ // proxy flags
false,
false,
- false,
+ true,
// is https request
true,
// proxies in retry map
@@ -714,11 +714,11 @@ TEST_F(DataReductionProxyParamsTest, AreProxiesBypassed) {
false,
true,
// expected result
- false,
+ true,
},
{ // proxy flags
- false,
- false,
+ true,
+ true,
true,
// is https request
true,
@@ -733,30 +733,45 @@ TEST_F(DataReductionProxyParamsTest, AreProxiesBypassed) {
},
{ // proxy flags
true,
- true,
- true,
+ false,
+ false,
// is https request
- true,
+ false,
// proxies in retry map
+ true,
false,
false,
false,
false,
- true,
// expected result
true,
},
{ // proxy flags
true,
- false,
+ true,
false,
// is https request
false,
// proxies in retry map
+ false,
+ true,
+ false,
+ false,
+ false,
+ // expected result
+ true,
+ },
+ { // proxy flags
+ false,
+ true,
true,
+ // is https request
+ false,
+ // proxies in retry map
false,
false,
false,
+ true,
false,
// expected result
true,

Powered by Google App Engine
This is Rietveld 408576698