Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Unified Diff: components/data_reduction_proxy/browser/data_reduction_proxy_params_unittest.cc

Issue 464023002: Fixed DataReductionProxyParams::AreProxiesBypassed logic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed bengr comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/browser/data_reduction_proxy_params_unittest.cc
diff --git a/components/data_reduction_proxy/browser/data_reduction_proxy_params_unittest.cc b/components/data_reduction_proxy/browser/data_reduction_proxy_params_unittest.cc
index 69a9ab6171135c7d398b1c02013e312aa0e75ccd..fd0b67654f92fdb989063c0502b638e6eef05041 100644
--- a/components/data_reduction_proxy/browser/data_reduction_proxy_params_unittest.cc
+++ b/components/data_reduction_proxy/browser/data_reduction_proxy_params_unittest.cc
@@ -768,6 +768,36 @@ TEST_F(DataReductionProxyParamsTest, AreProxiesBypassed) {
// is https request
false,
// proxies in retry map
+ false,
+ true,
+ false,
+ false,
+ false,
+ // expected result
+ true,
+ },
+ { // proxy flags
+ false,
+ true,
+ true,
+ // is https request
+ false,
+ // proxies in retry map
+ false,
+ false,
+ false,
+ true,
+ false,
+ // expected result
+ true,
+ },
+ { // proxy flags
+ true,
+ true,
+ false,
+ // is https request
+ false,
+ // proxies in retry map
true,
false,
false,

Powered by Google App Engine
This is Rietveld 408576698