Chromium Code Reviews
Help | Chromium Project | Sign in
(351)

Issue 464016: Fix for bug 512 from Subrato De, CodeAurora. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 4 months ago by Erik Corry
Modified:
4 years, 4 months ago
CC:
v8-dev_googlegroups.com,
Visibility:
Public.

Description

Fix for bug 512 from Subrato De, CodeAurora.

Committed: http://code.google.com/p/v8/source/detail?r=3435

Patch Set 1 #

Total comments: 3

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+247 lines, -230 lines) Lint Patch
M AUTHORS View 1 1 chunk +2 lines, -1 line 0 comments 0 errors Download
M src/arm/assembler-arm.h View 1 2 chunks +122 lines, -95 lines 0 comments 0 errors Download
M src/arm/assembler-arm.cc View 1 12 chunks +87 lines, -97 lines 0 comments 0 errors Download
M src/arm/codegen-arm.cc View 1 3 chunks +13 lines, -13 lines 0 comments 0 errors Download
M src/arm/disasm-arm.cc View 1 2 chunks +10 lines, -11 lines 0 comments 0 errors Download
M src/arm/macro-assembler-arm.cc View 1 1 chunk +3 lines, -3 lines 0 comments 0 errors Download
M src/arm/simulator-arm.cc View 1 2 chunks +10 lines, -10 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 3
Erik Corry
4 years, 4 months ago #1
Erik Corry
Thanks. This doesn't fix the VFP3 vs VFPv2 issue from http://code.google.com/p/v8/issues/detail?id=512 but that can be ...
4 years, 4 months ago #2
Mads Ager (chromium)
4 years, 4 months ago #3
http://codereview.chromium.org/464016/diff/1/2
File AUTHORS (right):

http://codereview.chromium.org/464016/diff/1/2#newcode23
AUTHORS:23: Subrato K De <subratokde@codeaurora.org>
On 2009/12/03 12:05:50, Erik Corry wrote:
> Since you are corporate contributors, your name and John's should be removed
and
> instead Code Aurora should be added after Google Inc.

I think either of the individual names or the corporation would be fine. 
Putting in the corporation instead of the individuals of course makes it easier
to keep this up to date.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6