Issue 464013002: Fix bounding box calculation for touches with radius of 0.

Issue 464013002: Fix bounding box calculation for touches with radius of 0. (Closed)

Created:
6 years, 4 months ago by tdresser

Modified:
6 years, 4 months ago

Reviewers:
jdduke (slow)

CC:
chromium-reviews, tdresser+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix bounding box calculation for touches with radius of 0. BUG=None TEST=GestureProviderTest.ZeroRadiusBoundingBox Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289151

Patch Set 2 : Address jdduke's comments. #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -8 lines)			Patch
	M	ui/events/gesture_detection/gesture_provider.cc	View		1 chunk	+13 lines, -7 lines	0 comments	Download
	M	ui/events/gesture_detection/gesture_provider_unittest.cc	View	1	2 chunks	+24 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

jdduke (slow)

lgtm with nit, good catch. https://codereview.chromium.org/464013002/diff/1/ui/events/gesture_detection/gesture_provider_unittest.cc File ui/events/gesture_detection/gesture_provider_unittest.cc (right): https://codereview.chromium.org/464013002/diff/1/ui/events/gesture_detection/gesture_provider_unittest.cc#newcode2350 ui/events/gesture_detection/gesture_provider_unittest.cc:2350: event.set_id(++motion_event_id); I'd ditch the ...

6 years, 4 months ago (2014-08-12 20:33:48 UTC) #2

tdresser

https://codereview.chromium.org/464013002/diff/1/ui/events/gesture_detection/gesture_provider_unittest.cc File ui/events/gesture_detection/gesture_provider_unittest.cc (right): https://codereview.chromium.org/464013002/diff/1/ui/events/gesture_detection/gesture_provider_unittest.cc#newcode2350 ui/events/gesture_detection/gesture_provider_unittest.cc:2350: event.set_id(++motion_event_id); On 2014/08/12 20:33:48, jdduke wrote: > I'd ditch ...

6 years, 4 months ago (2014-08-12 21:09:39 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/464013002/20001

6 years, 4 months ago (2014-08-12 21:14:18 UTC) #5

Message was sent while issue was closed.

Change committed as 289151

Expand Messages | Collapse Messages