Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 464003002: Convert net.js & net_unittests.js to html files (Closed)

Created:
6 years, 4 months ago by leviw_travelin_and_unemployed
Modified:
6 years, 4 months ago
Reviewers:
szager1, michaelpg, ojan
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Convert net.js & net_unittests.js to html files Moving them to lib, wrapping them in script tags, and converting the test to Mocha. BUG=400388 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180101

Patch Set 1 #

Patch Set 2 : Fix includes from old tests #

Patch Set 3 : Include tests in karma #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -179 lines) Patch
M Tools/GardeningServer/karma.conf.js View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + Tools/GardeningServer/lib/net.html View 2 chunks +28 lines, -24 lines 0 comments Download
A Tools/GardeningServer/lib/test/net-tests.html View 1 chunk +47 lines, -0 lines 0 comments Download
M Tools/GardeningServer/run-unittests.html View 1 1 chunk +0 lines, -2 lines 0 comments Download
D Tools/GardeningServer/scripts/net.js View 1 chunk +0 lines, -114 lines 0 comments Download
D Tools/GardeningServer/scripts/net_unittests.js View 1 chunk +0 lines, -39 lines 0 comments Download
M Tools/GardeningServer/test/unit-tests.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
leviw_travelin_and_unemployed
6 years, 4 months ago (2014-08-12 18:49:44 UTC) #1
michaelpg
On 2014/08/12 18:49:44, leviw wrote: If you add 'lib/test/*.html' to karma.conf.js, then net-tests will be ...
6 years, 4 months ago (2014-08-12 19:57:47 UTC) #2
leviw_travelin_and_unemployed
On 2014/08/12 at 19:57:47, michaelpg wrote: > On 2014/08/12 18:49:44, leviw wrote: > > If ...
6 years, 4 months ago (2014-08-12 20:44:06 UTC) #3
ojan
lgtm
6 years, 4 months ago (2014-08-12 21:29:15 UTC) #4
leviw_travelin_and_unemployed
The CQ bit was checked by leviw@chromium.org
6 years, 4 months ago (2014-08-12 21:30:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/leviw@chromium.org/464003002/40001
6 years, 4 months ago (2014-08-12 21:35:16 UTC) #6
commit-bot: I haz the power
6 years, 4 months ago (2014-08-12 21:37:33 UTC) #7
Message was sent while issue was closed.
Change committed as 180101

Powered by Google App Engine
This is Rietveld 408576698