Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: tests/PathOpsSkpClipTest.cpp

Issue 463883002: fix pathops skp-derived bugs; add more failing tests (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/pathops/SkOpSegment.cpp ('k') | tests/PathOpsSkpTest.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #include "CrashHandler.h" 1 #include "CrashHandler.h"
2 // #include "OverwriteLine.h" 2 // #include "OverwriteLine.h"
3 #include "Resources.h" 3 #include "Resources.h"
4 #include "SkBitmap.h" 4 #include "SkBitmap.h"
5 #include "SkCanvas.h" 5 #include "SkCanvas.h"
6 #include "SkColor.h" 6 #include "SkColor.h"
7 #include "SkColorPriv.h" 7 #include "SkColorPriv.h"
8 #include "SkCommandLineFlags.h" 8 #include "SkCommandLineFlags.h"
9 #include "SkDevice.h" 9 #include "SkDevice.h"
10 #include "SkForceLinking.h" 10 #include "SkForceLinking.h"
(...skipping 20 matching lines...) Expand all
31 const struct SkipOverTest { 31 const struct SkipOverTest {
32 int directory; 32 int directory;
33 const char* filename; 33 const char* filename;
34 bool blamePathOps; 34 bool blamePathOps;
35 } skipOver[] = { 35 } skipOver[] = {
36 { 2, "http___www_groupon_sg_.skp", false}, // SkAAClip::Builder::addRun SkA SSERT(fBounds.contains(x, y)); 36 { 2, "http___www_groupon_sg_.skp", false}, // SkAAClip::Builder::addRun SkA SSERT(fBounds.contains(x, y));
37 { 6, "http___www_googleventures_com_.skp", true}, // addTCoincident SkASSER T(test->fT < 1); 37 { 6, "http___www_googleventures_com_.skp", true}, // addTCoincident SkASSER T(test->fT < 1);
38 { 7, "http___www_foxsports_nl_.skp", true}, // (no repro on mac) addT SkASS ERT(this != other || fVerb == SkPath::kCubic_Verb) 38 { 7, "http___www_foxsports_nl_.skp", true}, // (no repro on mac) addT SkASS ERT(this != other || fVerb == SkPath::kCubic_Verb)
39 {13, "http___www_modernqigong_com_.skp", false}, // SkAAClip::Builder::addR un SkASSERT(fBounds.contains(x, y)); 39 {13, "http___www_modernqigong_com_.skp", false}, // SkAAClip::Builder::addR un SkASSERT(fBounds.contains(x, y));
40 {14, "http___www_devbridge_com_.skp", true}, // checkSmallCoincidence SkASS ERT(!next->fSmall || checkMultiple); 40 {14, "http___www_devbridge_com_.skp", true}, // checkSmallCoincidence SkASS ERT(!next->fSmall || checkMultiple);
41 {16, "http___www_1023world_net_.skp", true}, // bitmap decode assert (corru pt skp?) 41 {16, "http___www_1023world_net_.skp", false}, // bitmap decode assert (corr upt skp?)
42 {19, "http___www_alamdi_com_.skp", true}, // cubic/quad intersection 42 {19, "http___www_alamdi_com_.skp", true}, // cubic/quad intersection
43 {26, "http___www_liveencounters_net_.skp", true}, // (no repro on mac) chec kSmall addT:549 (line, expects cubic) 43 {26, "http___www_liveencounters_net_.skp", true}, // (no repro on mac) chec kSmall addT:549 (line, expects cubic)
44 {28, "http___www_encros_fr_.skp", false}, // SkAAClip::Builder::addRun SkAS SERT(fBounds.contains(x, y)); 44 {28, "http___www_encros_fr_.skp", false}, // SkAAClip::Builder::addRun SkAS SERT(fBounds.contains(x, y));
45 {37, "http___www_familysurvivalprotocol_wordpress_com_.skp", true}, // bump Span SkASSERT(span->fOppValue >= 0); 45 {37, "http___www_familysurvivalprotocol_wordpress_com_.skp", true}, // bump Span SkASSERT(span->fOppValue >= 0);
46 {39, "http___sufeinet_com_.skp", false}, // bitmap decode assert (corrupt sk p?) 46 {39, "http___sufeinet_com_.skp", false}, // bitmap decode assert (corrupt sk p?)
47 {41, "http___www_rano360_com_.skp", true}, // checkSmallCoincidence SkASSERT (!next->fSmall || checkMultiple); 47 {41, "http___www_rano360_com_.skp", true}, // checkSmallCoincidence SkASSERT (!next->fSmall || checkMultiple);
48 {44, "http___www_firstunitedbank_com_.skp", true}, // addTCancel SkASSERT(o Index > 0); 48 {44, "http___www_firstunitedbank_com_.skp", true}, // addTCancel SkASSERT(o Index > 0);
49 {46, "http___www_shinydemos_com_.skp", true}, // addSimpleAngle SkASSERT(in dex == count() - 2); 49 {46, "http___www_shinydemos_com_.skp", true}, // addSimpleAngle SkASSERT(in dex == count() - 2);
50 {48, "http___www_familysurvivalprotocol_com_.skp", true}, // bumpSpan SkASS ERT "span->fOppValue >= 0" 50 {48, "http___www_familysurvivalprotocol_com_.skp", true}, // bumpSpan SkASS ERT "span->fOppValue >= 0"
51 {57, "http___www_lptemp_com_.skp", true}, // addTCoincident oPeek = &other-> fTs[++oPeekIndex]; 51 {57, "http___www_lptemp_com_.skp", true}, // addTCoincident oPeek = &other-> fTs[++oPeekIndex];
(...skipping 1060 matching lines...) Expand 10 before | Expand all | Expand 10 after
1112 } 1112 }
1113 SkGraphics::Term(); 1113 SkGraphics::Term();
1114 return 0; 1114 return 0;
1115 } 1115 }
1116 1116
1117 #if !defined(SK_BUILD_FOR_IOS) && !defined(SK_BUILD_FOR_NACL) 1117 #if !defined(SK_BUILD_FOR_IOS) && !defined(SK_BUILD_FOR_NACL)
1118 int main(int argc, char * const argv[]) { 1118 int main(int argc, char * const argv[]) {
1119 return tool_main(argc, (char**) argv); 1119 return tool_main(argc, (char**) argv);
1120 } 1120 }
1121 #endif 1121 #endif
OLDNEW
« no previous file with comments | « src/pathops/SkOpSegment.cpp ('k') | tests/PathOpsSkpTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698