Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 463823002: Settings page: Do not grey out the "Ok Google" checkbox on errors. (Closed)

Created:
6 years, 4 months ago by Matt Giuca
Modified:
6 years, 4 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, kcarattini
Project:
chromium
Visibility:
Public.

Description

Settings page: Do not grey out the "Ok Google" checkbox on errors. Previously, if a mic is not plugged in or some other error occurs (e.g., NaCl is disabled), the checkbox is disabled. Now, the checkbox is always available to turn on or off (with the yellow triangle showing you whether there is an error). BUG=396993 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290201

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -17 lines) Patch
M chrome/browser/resources/options/browser_options.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/options/hotword_confirm_dialog.js View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/options/hotword_search_setting_indicator.js View 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Matt Giuca
rlp: For specific interest in this feature. dbeam: For OWNERS.
6 years, 4 months ago (2014-08-12 06:17:32 UTC) #1
rpetterson
On 2014/08/12 06:17:32, Matt Giuca wrote: > rlp: For specific interest in this feature. > ...
6 years, 4 months ago (2014-08-12 18:13:44 UTC) #2
Matt Giuca
The CQ bit was checked by mgiuca@chromium.org
6 years, 4 months ago (2014-08-12 23:34:28 UTC) #3
Matt Giuca
The CQ bit was unchecked by mgiuca@chromium.org
6 years, 4 months ago (2014-08-12 23:34:33 UTC) #4
Matt Giuca
dbeam: ping?
6 years, 4 months ago (2014-08-13 23:38:17 UTC) #5
Matt Giuca
+jhawkins: Please review for OWNERS (you're probably the most appropriate since you've reviewed Kendra's related ...
6 years, 4 months ago (2014-08-15 01:29:10 UTC) #6
Matt Giuca
If you LG this without issue, can you please check the commit box (to increase ...
6 years, 4 months ago (2014-08-15 04:23:02 UTC) #7
James Hawkins
lgtm
6 years, 4 months ago (2014-08-15 14:36:35 UTC) #8
Matt Giuca
The CQ bit was checked by mgiuca@chromium.org
6 years, 4 months ago (2014-08-17 23:46:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/463823002/1
6 years, 4 months ago (2014-08-17 23:46:28 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_compile_dbg on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-18 01:01:35 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-18 01:54:27 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (1) as 290201

Powered by Google App Engine
This is Rietveld 408576698