Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: chrome/test/data/file_manager/unit_tests/file_operation_manager_unittest.js

Issue 463783002: Combine consecutive entry-changed events into one. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed pointed bugs and handle errors. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/file_manager/file_manager/background/js/file_operation_manager.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/file_manager/unit_tests/file_operation_manager_unittest.js
diff --git a/chrome/test/data/file_manager/unit_tests/file_operation_manager_unittest.js b/chrome/test/data/file_manager/unit_tests/file_operation_manager_unittest.js
index e2fe9f0c3d0d4d5280d6ea5e526173e313c84440..ffb4c454f11807b8ee9a7ba068338eeb5c84a010 100644
--- a/chrome/test/data/file_manager/unit_tests/file_operation_manager_unittest.js
+++ b/chrome/test/data/file_manager/unit_tests/file_operation_manager_unittest.js
@@ -219,7 +219,7 @@ function testCopy(callback) {
if (event.reason === 'SUCCESS')
fulfill(events);
});
- fileOperationManager.addEventListener('entry-changed', function(event) {
+ fileOperationManager.addEventListener('entries-changed', function(event) {
events.push(event);
});
});
@@ -239,8 +239,8 @@ function testCopy(callback) {
assertEquals(10, lastEvent.status.totalBytes);
assertTrue(events.some(function(event) {
- return event.type === 'entry-changed' &&
- event.entry === targetEntry;
+ return event.type === 'entries-changed' &&
hirono 2014/08/15 09:13:59 Sorry I added more tests here. Could you rebase it
fukino 2014/08/15 10:22:27 Done.
+ event.entries[0] === targetEntry;
}));
}), callback);
« no previous file with comments | « no previous file | ui/file_manager/file_manager/background/js/file_operation_manager.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698