Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(969)

Issue 463753002: Stop compiling a bunch of unused renderer extensions code when extensions are disabled. (Closed)

Created:
6 years, 4 months ago by Lei Zhang
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Stop compiling a bunch of unused renderer extensions code when extensions are disabled. BUG=402728 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289162

Patch Set 1 #

Patch Set 2 : remove more files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -52 lines) Patch
M chrome/chrome_renderer.gypi View 1 4 chunks +52 lines, -52 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Lei Zhang
6 years, 4 months ago (2014-08-12 02:23:18 UTC) #1
not at google - send to devlin
lgtm, sweet.
6 years, 4 months ago (2014-08-12 20:03:31 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 4 months ago (2014-08-12 20:05:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/463753002/20001
6 years, 4 months ago (2014-08-12 20:08:08 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-13 00:56:52 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 02:53:50 UTC) #6
Message was sent while issue was closed.
Change committed as 289162

Powered by Google App Engine
This is Rietveld 408576698