Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 463733003: Move the implementation of HomeCardImpl out of the class declaration (Closed)

Created:
6 years, 4 months ago by pkotwicz
Modified:
6 years, 4 months ago
Reviewers:
oshima
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Move the implementation of HomeCardImpl out of the class declaration BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289281

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -87 lines) Patch
M athena/home/home_card_impl.cc View 1 3 chunks +102 lines, -87 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
pkotwicz
Oshima, PTAL
6 years, 4 months ago (2014-08-12 01:34:41 UTC) #1
oshima
lgtm Can you update the CL description with motivation?
6 years, 4 months ago (2014-08-12 17:26:31 UTC) #2
pkotwicz
I originally wrote the CL for the sake of https://codereview.chromium.org/465803002/ Given the recent refactoring of ...
6 years, 4 months ago (2014-08-13 12:40:13 UTC) #3
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 4 months ago (2014-08-13 12:40:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/463733003/70001
6 years, 4 months ago (2014-08-13 12:40:40 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-13 13:54:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (70001) as 289281

Powered by Google App Engine
This is Rietveld 408576698