Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 463683002: Get rid of testlistjson query parameter. (Closed)

Created:
6 years, 4 months ago by ojan
Modified:
6 years, 4 months ago
Reviewers:
szager1
CC:
blink-reviews, Sergiy Byelozyorov
Project:
blink
Visibility:
Public.

Description

Get rid of testlistjson query parameter. This is an optimization to make it so that we don't have to send the whole results.json file down since the JSONResultsGenerator needs this to figure out which tests it can strip. The only code left that uses this is the Android fork of this code, which needs to go away. So, I'm not OK with keeping this special-cased code in the generic test results server just for that. Deleting the code means that the requests will get the full results.json file instead of the one with the results and times stripped out. TBR because this is causing 500s on the live server and that push can't be rolled back without breaking other things. TBR=szager@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180005

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -76 lines) Patch
M Tools/TestResultServer/handlers/testfilehandler.py View 4 chunks +0 lines, -19 lines 0 comments Download
M Tools/TestResultServer/model/jsonresults.py View 1 chunk +0 lines, -27 lines 0 comments Download
M Tools/TestResultServer/model/jsonresults_unittest.py View 3 chunks +1 line, -30 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ojan
6 years, 4 months ago (2014-08-11 23:25:31 UTC) #1
ojan
6 years, 4 months ago (2014-08-11 23:26:07 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as 180005.

Powered by Google App Engine
This is Rietveld 408576698