Blacklist very old ATI drivers from D3D11 due to performance issues.

Blacklist very old ATI drivers from D3D11 due to performance issues.

BUG=402134
TEST=gpu_unittests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=289603

[vangelis, 2014-08-12 14:37:56]

An alternative way just to be on the safe side would be to blacklist AMD based
on the driver date. As it is, we're really permissive by allowing drivers to go
back to 2009. What if we just blacklist D3D11 for AMD for drivers < 2011 ?

[vangelis, 2014-08-12 16:11:44]

On 2014/08/12 14:37:56, vangelis wrote:
> An alternative way just to be on the safe side would be to blacklist AMD based
> on the driver date. As it is, we're really permissive by allowing drivers to
go
> back to 2009. What if we just blacklist D3D11 for AMD for drivers < 2011 ?

Shannon, also please use BUG=402134 so that we can keep track of the change.

[Shannon Woods, 2014-08-12 17:25:13]

On 2014/08/12 16:11:44, vangelis wrote:
> On 2014/08/12 14:37:56, vangelis wrote:
> > An alternative way just to be on the safe side would be to blacklist AMD
based
> > on the driver date. As it is, we're really permissive by allowing drivers to
> go
> > back to 2009. What if we just blacklist D3D11 for AMD for drivers < 2011 ?
> 
> Shannon, also please use BUG=402134 so that we can keep track of the change.

Changed it to use the date instead of the driver version. Also added the bug ID
to the commit message, but that doesn't appear to update the description in
Rietveld.

[Zhenyao Mo, 2014-08-12 18:31:04]

shannon, you also need to adjust the CL description (revision commit messages
won't show up in the description automatically).

You can either do "git cl description" to update it, or on this site, use "Edit
Issue" to edit it.

https://codereview.chromium.org/463673002/diff/40001/gpu/config/gpu_driver_bu...
File gpu/config/gpu_driver_bug_list_json.cc (right):

https://codereview.chromium.org/463673002/diff/40001/gpu/config/gpu_driver_bu...
gpu/config/gpu_driver_bug_list_json.cc:22: "version": "7.0",
This should be 6.10.  We only update major version if the blacklist logic
changes, not the data entries.

https://codereview.chromium.org/463673002/diff/40001/gpu/config/gpu_driver_bu...
gpu/config/gpu_driver_bug_list_json.cc:1088: }
you need a "," here, otherwise json loader will fail.

[Shannon Woods, 2014-08-13 16:21:38]

On 2014/08/12 18:31:04, Zhenyao Mo wrote:
> shannon, you also need to adjust the CL description (revision commit messages
> won't show up in the description automatically).
> 
> You can either do "git cl description" to update it, or on this site, use
"Edit
> Issue" to edit it.
> 
>
https://codereview.chromium.org/463673002/diff/40001/gpu/config/gpu_driver_bu...
> File gpu/config/gpu_driver_bug_list_json.cc (right):
> 
>
https://codereview.chromium.org/463673002/diff/40001/gpu/config/gpu_driver_bu...
> gpu/config/gpu_driver_bug_list_json.cc:22: "version": "7.0",
> This should be 6.10.  We only update major version if the blacklist logic
> changes, not the data entries.
> 
>
https://codereview.chromium.org/463673002/diff/40001/gpu/config/gpu_driver_bu...
> gpu/config/gpu_driver_bug_list_json.cc:1088: }
> you need a "," here, otherwise json loader will fail.

Ok, fixed. PTAL.

[Zhenyao Mo, 2014-08-13 19:38:12]

LGTM

I also updated the description to add a TEST=gpu_unittests

[Shannon Woods, 2014-08-13 19:51:31]

The CQ bit was checked by shannonwoods@chromium.org

[commit-bot: I haz the power, 2014-08-13 19:53:37]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/shannonwoods@chromium.org/463673002/60001

[commit-bot: I haz the power, 2014-08-14 10:52:53]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)

[commit-bot: I haz the power, 2014-08-14 15:55:04]

Committed patchset #4 (60001) as 289603