Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Side by Side Diff: ui/display/chromeos/display_configurator_unittest.cc

Issue 463633005: On resume perform a delayed call to SetDisplayPower() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/display/chromeos/display_configurator.h" 5 #include "ui/display/chromeos/display_configurator.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include <cmath> 9 #include <cmath>
10 #include <cstdarg> 10 #include <cstdarg>
(...skipping 830 matching lines...) Expand 10 before | Expand all | Expand 10 after
841 841
842 TEST_F(DisplayConfiguratorTest, SuspendAndResume) { 842 TEST_F(DisplayConfiguratorTest, SuspendAndResume) {
843 InitWithSingleOutput(); 843 InitWithSingleOutput();
844 844
845 // No preparation is needed before suspending when the display is already 845 // No preparation is needed before suspending when the display is already
846 // on. The configurator should still reprobe on resume in case a display 846 // on. The configurator should still reprobe on resume in case a display
847 // was connected while suspended. 847 // was connected while suspended.
848 configurator_.SuspendDisplays(); 848 configurator_.SuspendDisplays();
849 EXPECT_EQ(kNoActions, log_->GetActionsAndClear()); 849 EXPECT_EQ(kNoActions, log_->GetActionsAndClear());
850 configurator_.ResumeDisplays(); 850 configurator_.ResumeDisplays();
851 test_api_.TriggerConfigureTimeout();
Daniel Erat 2014/08/12 21:00:04 you should be testing the return value here to ver
dnicoara 2014/08/12 21:46:20 Done.
851 EXPECT_EQ( 852 EXPECT_EQ(
852 JoinActions( 853 JoinActions(
853 kGrab, 854 kGrab,
854 GetFramebufferAction(small_mode_.size(), &outputs_[0], NULL).c_str(), 855 GetFramebufferAction(small_mode_.size(), &outputs_[0], NULL).c_str(),
855 GetCrtcAction(outputs_[0], &small_mode_, gfx::Point(0, 0)).c_str(), 856 GetCrtcAction(outputs_[0], &small_mode_, gfx::Point(0, 0)).c_str(),
856 kForceDPMS, 857 kForceDPMS,
857 kUngrab, 858 kUngrab,
858 NULL), 859 NULL),
859 log_->GetActionsAndClear()); 860 log_->GetActionsAndClear());
860 861
(...skipping 16 matching lines...) Expand all
877 kGrab, 878 kGrab,
878 GetFramebufferAction(small_mode_.size(), &outputs_[0], NULL).c_str(), 879 GetFramebufferAction(small_mode_.size(), &outputs_[0], NULL).c_str(),
879 GetCrtcAction(outputs_[0], &small_mode_, gfx::Point(0, 0)).c_str(), 880 GetCrtcAction(outputs_[0], &small_mode_, gfx::Point(0, 0)).c_str(),
880 kForceDPMS, 881 kForceDPMS,
881 kUngrab, 882 kUngrab,
882 kSync, 883 kSync,
883 NULL), 884 NULL),
884 log_->GetActionsAndClear()); 885 log_->GetActionsAndClear());
885 886
886 configurator_.ResumeDisplays(); 887 configurator_.ResumeDisplays();
888 test_api_.TriggerConfigureTimeout();
887 EXPECT_EQ( 889 EXPECT_EQ(
888 JoinActions( 890 JoinActions(
889 kGrab, 891 kGrab,
890 GetFramebufferAction(small_mode_.size(), &outputs_[0], NULL).c_str(), 892 GetFramebufferAction(small_mode_.size(), &outputs_[0], NULL).c_str(),
891 GetCrtcAction(outputs_[0], &small_mode_, gfx::Point(0, 0)).c_str(), 893 GetCrtcAction(outputs_[0], &small_mode_, gfx::Point(0, 0)).c_str(),
892 kForceDPMS, 894 kForceDPMS,
893 kUngrab, 895 kUngrab,
894 NULL), 896 NULL),
895 log_->GetActionsAndClear()); 897 log_->GetActionsAndClear());
896 898
(...skipping 25 matching lines...) Expand all
922 log_->GetActionsAndClear()); 924 log_->GetActionsAndClear());
923 925
924 configurator_.SuspendDisplays(); 926 configurator_.SuspendDisplays();
925 EXPECT_EQ(JoinActions(kGrab, kUngrab, kSync, NULL), 927 EXPECT_EQ(JoinActions(kGrab, kUngrab, kSync, NULL),
926 log_->GetActionsAndClear()); 928 log_->GetActionsAndClear());
927 929
928 // If a display is disconnected while suspended, the configurator should 930 // If a display is disconnected while suspended, the configurator should
929 // pick up the change. 931 // pick up the change.
930 UpdateOutputs(1, false); 932 UpdateOutputs(1, false);
931 configurator_.ResumeDisplays(); 933 configurator_.ResumeDisplays();
934 test_api_.TriggerConfigureTimeout();
932 EXPECT_EQ( 935 EXPECT_EQ(
933 JoinActions( 936 JoinActions(
934 kGrab, 937 kGrab,
935 GetFramebufferAction(small_mode_.size(), &outputs_[0], NULL).c_str(), 938 GetFramebufferAction(small_mode_.size(), &outputs_[0], NULL).c_str(),
936 GetCrtcAction(outputs_[0], NULL, gfx::Point(0, 0)).c_str(), 939 GetCrtcAction(outputs_[0], NULL, gfx::Point(0, 0)).c_str(),
937 kUngrab, 940 kUngrab,
938 NULL), 941 NULL),
939 log_->GetActionsAndClear()); 942 log_->GetActionsAndClear());
940 } 943 }
941 944
(...skipping 356 matching lines...) Expand 10 before | Expand all | Expand 10 after
1298 gfx::Point(0, 1301 gfx::Point(0,
1299 modes[0]->size().height() + 1302 modes[0]->size().height() +
1300 DisplayConfigurator::kVerticalGap)) 1303 DisplayConfigurator::kVerticalGap))
1301 .c_str(), 1304 .c_str(),
1302 kUngrab, 1305 kUngrab,
1303 NULL), 1306 NULL),
1304 log_->GetActionsAndClear()); 1307 log_->GetActionsAndClear());
1305 } 1308 }
1306 1309
1307 } // namespace ui 1310 } // namespace ui
OLDNEW
« ui/display/chromeos/display_configurator.cc ('K') | « ui/display/chromeos/display_configurator.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698