Issue 463633002: Revert "Cleanup deadcode in Rendering"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 463633002: Revert "Cleanup deadcode in Rendering" (Closed)

Created:
6 years, 4 months ago by pdr.

Modified:
6 years, 4 months ago

Reviewers:
leviw_travelin_and_unemployed

CC:
blink-reviews, blink-reviews-rendering, chromiumbugtracker_adobe.com, zoltan1, blink-reviews-html_chromium.org, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, jchaffraix+rendering, pdr., rune+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Revert "Cleanup deadcode in Rendering" This reverts commit 25a48eab31ad4f0a54bcaea1ead2b0cc4dec74d2 [1] with the exception of the changes in RenderFlowThread which have additional changes on top of them and do not cleanly revert. This is a speculative rollout, see crbug.com/402059. [1] https://src.chromium.org/viewvc/blink?view=rev&revision=179521 BUG=402059 TBR=leviw NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179989

Patch Set 1 #

Patch Set 2 : Rebase #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -0 lines)			Patch
M	Source/core/html/HTMLSelectElement.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/html/HTMLSelectElement.cpp	View		1 chunk	+12 lines, -0 lines	0 comments	Download
M	Source/core/rendering/RenderBlock.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/rendering/RenderBlock.cpp	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download
M	Source/core/rendering/RenderImage.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/rendering/RenderListMarker.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/rendering/RenderListMarker.cpp	View	1	1 chunk	+21 lines, -0 lines	0 comments	Download
M	Source/core/rendering/RenderMenuList.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/rendering/RenderMenuList.cpp	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	Source/core/rendering/RenderRegion.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	Source/core/rendering/RenderRegion.cpp	View		1 chunk	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/463633002/20001

6 years, 4 months ago (2014-08-11 20:36:27 UTC) #2

Message was sent while issue was closed.

Change committed as 179989

Expand Messages | Collapse Messages