Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 463603002: clean up render_pdfs: (Closed)

Created:
6 years, 4 months ago by hal.canary
Modified:
6 years, 4 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

clean up render_pdfs: Remove unused headers replace dynamic memory wstream with null wstream. Use SkAutoTDelete when appropriate. Replace PdfRenderer class with short function: pdf_to_stream. Collapse render_pdf, process_input, tool_main_core functions Split out process_input_files function. Don't crash when no arguments given. print out max rss on each skp. prettier output Committed: https://skia.googlesource.com/skia/+/8b2cb3391d75f0e7b522ab3180da833370f413bd

Patch Set 1 : AnotherPatchSet #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -206 lines) Patch
M gyp/tools.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D tools/PdfRenderer.h View 1 chunk +0 lines, -67 lines 0 comments Download
D tools/PdfRenderer.cpp View 1 chunk +0 lines, -60 lines 0 comments Download
M tools/render_pdfs_main.cpp View 6 chunks +97 lines, -77 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
hal.canary
The CQ bit was checked by halcanary@google.com
6 years, 4 months ago (2014-08-11 19:57:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/463603002/20001
6 years, 4 months ago (2014-08-11 19:57:20 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 4 months ago (2014-08-11 19:57:21 UTC) #3
hal.canary
ptal
6 years, 4 months ago (2014-08-11 20:03:19 UTC) #4
hal.canary
The CQ bit was unchecked by halcanary@google.com
6 years, 4 months ago (2014-08-11 20:03:22 UTC) #5
mtklein
lgtm
6 years, 4 months ago (2014-08-11 20:05:18 UTC) #6
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 4 months ago (2014-08-11 20:07:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/463603002/20001
6 years, 4 months ago (2014-08-11 20:08:21 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-11 20:08:31 UTC) #9
Message was sent while issue was closed.
Change committed as 8b2cb3391d75f0e7b522ab3180da833370f413bd

Powered by Google App Engine
This is Rietveld 408576698