Source/modules/push_messaging/PushRegistration.h - Issue 463543002: Oilpan: Ensure that classes with virtual trace methods always have vtables for their left-most base…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/push_messaging/PushRegistration.h

Issue 463543002: Oilpan: Ensure that classes with virtual trace methods always have vtables for their left-most base… (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/fetch/ResourceClient.h ('K') | « Source/modules/mediastream/UserMediaRequest.h ('k') | Source/modules/serviceworkers/FetchBodyStream.h » ('j') | Source/platform/LifecycleContext.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/push_messaging/PushRegistration.h

diff --git a/Source/modules/push_messaging/PushRegistration.h b/Source/modules/push_messaging/PushRegistration.h

index aee30624d8652a8108ad977bef558af6380f986a..dc434d6fdd407da582bdf2f06839d91f408e161c 100644

--- a/Source/modules/push_messaging/PushRegistration.h

+++ b/Source/modules/push_messaging/PushRegistration.h

@@ -26,7 +26,7 @@ public:

const String& pushEndpoint() const { return m_pushEndpoint; }

const String& pushRegistrationId() const { return m_pushRegistrationId; }

- void trace(Visitor*) { }

+ virtual void trace(Visitor*) { }

private:

PushRegistration(const String& pushEndpoint, const String& pushRegistrationId);