Source/core/imagebitmap/ImageBitmapFactories.h - Issue 463543002: Oilpan: Ensure that classes with virtual trace methods always have vtables for their left-most base…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/imagebitmap/ImageBitmapFactories.h

Issue 463543002: Oilpan: Ensure that classes with virtual trace methods always have vtables for their left-most base… (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/fetch/ResourceClient.h ('K') | « Source/core/html/track/vtt/VTTRegion.h ('k') | Source/core/inspector/InspectorController.cpp » ('j') | Source/platform/LifecycleContext.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/imagebitmap/ImageBitmapFactories.h

diff --git a/Source/core/imagebitmap/ImageBitmapFactories.h b/Source/core/imagebitmap/ImageBitmapFactories.h

index 3cc1e303d661419b14e92008c81d036fd01fb86f..a6fdea71c1e21a528d16dabede720557c0ce2986 100644

--- a/Source/core/imagebitmap/ImageBitmapFactories.h

+++ b/Source/core/imagebitmap/ImageBitmapFactories.h

@@ -91,7 +91,7 @@ private:

void loadBlobAsync(ExecutionContext*, Blob*);

ScriptPromise promise() { return m_resolver->promise(); }

- void trace(Visitor*);

+ virtual void trace(Visitor*);

virtual ~ImageBitmapLoader() { }

« Source/core/fetch/ResourceClient.h ('K') | « Source/core/html/track/vtt/VTTRegion.h ('k') | Source/core/inspector/InspectorController.cpp » ('j') | Source/platform/LifecycleContext.h » ('J')