Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Side by Side Diff: Source/core/frame/BarProp.h

Issue 463543002: Oilpan: Ensure that classes with virtual trace methods always have vtables for their left-most base… (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2007 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 public: 43 public:
44 enum Type { Locationbar, Menubar, Personalbar, Scrollbars, Statusbar, To olbar }; 44 enum Type { Locationbar, Menubar, Personalbar, Scrollbars, Statusbar, To olbar };
45 45
46 static PassRefPtrWillBeRawPtr<BarProp> create(LocalFrame* frame, Type ty pe) 46 static PassRefPtrWillBeRawPtr<BarProp> create(LocalFrame* frame, Type ty pe)
47 { 47 {
48 return adoptRefWillBeNoop(new BarProp(frame, type)); 48 return adoptRefWillBeNoop(new BarProp(frame, type));
49 } 49 }
50 50
51 bool visible() const; 51 bool visible() const;
52 52
53 void trace(Visitor*) { } 53 virtual void trace(Visitor*) { }
54 54
55 private: 55 private:
56 BarProp(LocalFrame*, Type); 56 BarProp(LocalFrame*, Type);
57 Type m_type; 57 Type m_type;
58 }; 58 };
59 59
60 } // namespace blink 60 } // namespace blink
61 61
62 #endif // BarProp_h 62 #endif // BarProp_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698